1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323
/*
* Copyright 2022-2023 Amazon.com, Inc. or its affiliates. All Rights Reserved.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* https://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/
use super::{Expr, ExprKind, Literal, Name};
use crate::entities::JsonSerializationError;
use crate::parser;
use serde::{Deserialize, Serialize};
use smol_str::SmolStr;
use std::hash::{Hash, Hasher};
use std::ops::Deref;
use thiserror::Error;
/// A few places in Core use these "restricted expressions" (for lack of a
/// better term) which are in some sense the minimal subset of `Expr` required
/// to express all possible `Value`s.
///
/// Specifically, "restricted" expressions are
/// defined as expressions containing only the following:
/// - bool, int, and string literals
/// - literal EntityUIDs such as User::"alice"
/// - extension function calls, where the arguments must be other things
/// on this list
/// - set and record literals, where the values must be other things on
/// this list
///
/// That means the following are not allowed in "restricted" expressions:
/// - `principal`, `action`, `resource`, `context`
/// - builtin operators and functions, including `.`, `in`, `has`, `like`,
/// `.contains()`
/// - if-then-else expressions
///
/// These restrictions represent the expressions that are allowed to appear as
/// attribute values in `Slice` and `Context`.
#[derive(Deserialize, Serialize, Hash, Debug, Clone, PartialEq, Eq)]
#[serde(transparent)]
pub struct RestrictedExpr(Expr);
impl RestrictedExpr {
/// Create a new `RestrictedExpr` from an `Expr`.
///
/// This function is "safe" in the sense that it will verify that the
/// provided `expr` does indeed qualify as a "restricted" expression,
/// returning an error if not.
///
/// Note this check requires recursively walking the AST. For a version of
/// this function that doesn't perform this check, see `new_unchecked()`
/// below.
pub fn new(expr: Expr) -> Result<Self, RestrictedExpressionError> {
is_restricted(&expr)?;
Ok(Self(expr))
}
/// Create a new `RestrictedExpr` from an `Expr`, where the caller is
/// responsible for ensuring that the `Expr` is a valid "restricted
/// expression". If it is not, internal invariants will be violated, which
/// may lead to other errors later, panics, or even incorrect results.
///
/// For a "safer" version of this function that returns an error for invalid
/// inputs, see `new()` above.
pub fn new_unchecked(expr: Expr) -> Self {
// in debug builds, this does the check anyway, panicking if it fails
if cfg!(debug_assertions) {
// PANIC SAFETY: We're in debug mode and panicking intentionally
#[allow(clippy::unwrap_used)]
Self::new(expr).unwrap()
} else {
Self(expr)
}
}
/// Create a `RestrictedExpr` that's just a single `Literal`.
///
/// Note that you can pass this a `Literal`, an `i64`, a `String`, etc.
pub fn val(v: impl Into<Literal>) -> Self {
// All literals are valid restricted-exprs
Self::new_unchecked(Expr::val(v))
}
/// Create a `RestrictedExpr` which evaluates to a Set of the given `RestrictedExpr`s
pub fn set(exprs: impl IntoIterator<Item = RestrictedExpr>) -> Self {
// Set expressions are valid restricted-exprs if their elements are; and
// we know the elements are because we require `RestrictedExpr`s in the
// parameter
Self::new_unchecked(Expr::set(exprs.into_iter().map(Into::into)))
}
/// Create a `RestrictedExpr` which evaluates to a Record with the given (key, value) pairs.
pub fn record(pairs: impl IntoIterator<Item = (SmolStr, RestrictedExpr)>) -> Self {
// Record expressions are valid restricted-exprs if their elements are;
// and we know the elements are because we require `RestrictedExpr`s in
// the parameter
Self::new_unchecked(Expr::record(pairs.into_iter().map(|(k, v)| (k, v.into()))))
}
/// Create a `RestrictedExpr` which calls the given extension function
pub fn call_extension_fn(function_name: Name, args: Vec<RestrictedExpr>) -> Self {
// Extension-function calls are valid restricted-exprs if their
// arguments are; and we know the arguments are because we require
// `RestrictedExpr`s in the parameter
Self::new_unchecked(Expr::call_extension_fn(
function_name,
args.into_iter().map(Into::into).collect(),
))
}
}
impl std::str::FromStr for RestrictedExpr {
type Err = parser::err::ParseErrors;
fn from_str(s: &str) -> Result<RestrictedExpr, Self::Err> {
parser::parse_restrictedexpr(s)
}
}
/// While `RestrictedExpr` wraps an _owned_ `Expr`, `BorrowedRestrictedExpr`
/// wraps a _borrowed_ `Expr`, with the same invariants.
#[derive(Serialize, Hash, Debug, Clone, PartialEq, Eq)]
pub struct BorrowedRestrictedExpr<'a>(&'a Expr);
impl<'a> BorrowedRestrictedExpr<'a> {
/// Create a new `BorrowedRestrictedExpr` from an `&Expr`.
///
/// This function is "safe" in the sense that it will verify that the
/// provided `expr` does indeed qualify as a "restricted" expression,
/// returning an error if not.
///
/// Note this check requires recursively walking the AST. For a version of
/// this function that doesn't perform this check, see `new_unchecked()`
/// below.
pub fn new(expr: &'a Expr) -> Result<Self, RestrictedExpressionError> {
is_restricted(expr)?;
Ok(Self(expr))
}
/// Create a new `BorrowedRestrictedExpr` from an `&Expr`, where the caller
/// is responsible for ensuring that the `Expr` is a valid "restricted
/// expression". If it is not, internal invariants will be violated, which
/// may lead to other errors later, panics, or even incorrect results.
///
/// For a "safer" version of this function that returns an error for invalid
/// inputs, see `new()` above.
pub fn new_unchecked(expr: &'a Expr) -> Self {
// in debug builds, this does the check anyway, panicking if it fails
if cfg!(debug_assertions) {
// PANIC SAFETY: We're in debug mode and panicking intentionally
#[allow(clippy::unwrap_used)]
Self::new(expr).unwrap()
} else {
Self(expr)
}
}
/// Write a BorrowedRestrictedExpr in "natural JSON" format.
///
/// Used to output the context as a map from Strings to JSON Values
pub fn to_natural_json(self) -> Result<serde_json::Value, JsonSerializationError> {
Ok(serde_json::to_value(
crate::entities::JSONValue::from_expr(self)?,
)?)
}
}
/// Helper function: does the given `Expr` qualify as a "restricted" expression.
///
/// Returns `Ok(())` if yes, or a `RestrictedExpressionError` if no.
fn is_restricted(expr: &Expr) -> Result<(), RestrictedExpressionError> {
match expr.expr_kind() {
ExprKind::Lit(_) => Ok(()),
ExprKind::Unknown { .. } => Ok(()),
ExprKind::Var(_) => Err(RestrictedExpressionError::InvalidRestrictedExpression {
feature: expr.to_string(),
}),
ExprKind::Slot(_) => Err(RestrictedExpressionError::InvalidRestrictedExpression {
feature: "template slots".into(),
}),
ExprKind::If { .. } => Err(RestrictedExpressionError::InvalidRestrictedExpression {
feature: "if-then-else".into(),
}),
ExprKind::And { .. } => Err(RestrictedExpressionError::InvalidRestrictedExpression {
feature: "&&".into(),
}),
ExprKind::Or { .. } => Err(RestrictedExpressionError::InvalidRestrictedExpression {
feature: "||".into(),
}),
ExprKind::UnaryApp { op, .. } => {
Err(RestrictedExpressionError::InvalidRestrictedExpression {
feature: op.to_string(),
})
}
ExprKind::BinaryApp { op, .. } => {
Err(RestrictedExpressionError::InvalidRestrictedExpression {
feature: op.to_string(),
})
}
ExprKind::GetAttr { .. } => Err(RestrictedExpressionError::InvalidRestrictedExpression {
feature: "attribute accesses".into(),
}),
ExprKind::HasAttr { .. } => Err(RestrictedExpressionError::InvalidRestrictedExpression {
feature: "'has'".into(),
}),
ExprKind::Like { .. } => Err(RestrictedExpressionError::InvalidRestrictedExpression {
feature: "'like'".into(),
}),
ExprKind::ExtensionFunctionApp { args, .. } => args.iter().try_for_each(is_restricted),
ExprKind::Set(exprs) => exprs.iter().try_for_each(is_restricted),
ExprKind::Record { pairs } => pairs.iter().map(|(_, v)| v).try_for_each(is_restricted),
}
}
// converting into Expr is always safe; restricted exprs are always valid Exprs
impl From<RestrictedExpr> for Expr {
fn from(r: RestrictedExpr) -> Expr {
r.0
}
}
impl AsRef<Expr> for RestrictedExpr {
fn as_ref(&self) -> &Expr {
&self.0
}
}
impl Deref for RestrictedExpr {
type Target = Expr;
fn deref(&self) -> &Expr {
self.as_ref()
}
}
impl std::fmt::Display for RestrictedExpr {
fn fmt(&self, f: &mut std::fmt::Formatter<'_>) -> std::fmt::Result {
write!(f, "{}", &self.0)
}
}
// converting into Expr is always safe; restricted exprs are always valid Exprs
impl<'a> From<BorrowedRestrictedExpr<'a>> for &'a Expr {
fn from(r: BorrowedRestrictedExpr<'a>) -> &'a Expr {
r.0
}
}
impl<'a> AsRef<Expr> for BorrowedRestrictedExpr<'a> {
fn as_ref(&self) -> &'a Expr {
self.0
}
}
impl RestrictedExpr {
/// Turn an `&RestrictedExpr` into a `BorrowedRestrictedExpr`
pub fn as_borrowed(&self) -> BorrowedRestrictedExpr<'_> {
BorrowedRestrictedExpr::new_unchecked(self.as_ref())
}
}
impl<'a> Deref for BorrowedRestrictedExpr<'a> {
type Target = Expr;
fn deref(&self) -> &'a Expr {
self.0
}
}
impl<'a> std::fmt::Display for BorrowedRestrictedExpr<'a> {
fn fmt(&self, f: &mut std::fmt::Formatter<'_>) -> std::fmt::Result {
write!(f, "{}", &self.0)
}
}
/// Like `ExprShapeOnly`, but for restricted expressions.
///
/// A newtype wrapper around (borrowed) restricted expressions that provides
/// `Eq` and `Hash` implementations that ignore any source information or other
/// generic data used to annotate the expression.
#[derive(Eq, Debug, Clone)]
pub struct RestrictedExprShapeOnly<'a>(BorrowedRestrictedExpr<'a>);
impl<'a> RestrictedExprShapeOnly<'a> {
/// Construct a `RestrictedExprShapeOnly` from a `BorrowedRestrictedExpr`.
/// The `BorrowedRestrictedExpr` is not modified, but any comparisons on the
/// resulting `RestrictedExprShapeOnly` will ignore source information and
/// generic data.
pub fn new(e: BorrowedRestrictedExpr<'a>) -> RestrictedExprShapeOnly<'a> {
RestrictedExprShapeOnly(e)
}
}
impl<'a> PartialEq for RestrictedExprShapeOnly<'a> {
fn eq(&self, other: &Self) -> bool {
self.0.eq_shape(&other.0)
}
}
impl<'a> Hash for RestrictedExprShapeOnly<'a> {
fn hash<H: Hasher>(&self, state: &mut H) {
self.0.hash_shape(state);
}
}
/// Errors generated in the restricted_expr module
#[derive(Debug, Clone, PartialEq, Hash, Error)]
pub enum RestrictedExpressionError {
/// A "restricted" expression contained a feature that is not allowed
/// in "restricted" expressions. The `feature` is just a string description
/// of the feature that is not allowed.
#[error("not allowed to use {feature} in a restricted expression")]
InvalidRestrictedExpression {
/// what disallowed feature appeared in the expression
feature: String,
},
}