cedar_policy_core/ast/id.rs
1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341 342 343 344 345 346 347 348 349 350 351 352 353 354 355 356 357 358 359 360 361 362 363 364 365 366 367 368 369 370 371 372 373 374 375 376 377 378 379 380 381 382 383 384 385 386 387 388 389 390 391 392 393 394 395 396 397 398
/*
* Copyright Cedar Contributors
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* https://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/
use serde::{Deserialize, Deserializer, Serialize};
use smol_str::SmolStr;
use crate::{parser::err::ParseErrors, FromNormalizedStr};
use super::{InternalName, ReservedNameError};
const RESERVED_ID: &str = "__cedar";
/// Identifiers. Anything in `Id` should be a valid identifier, this means it
/// does not contain, for instance, spaces or characters like '+'; and also is
/// not one of the Cedar reserved identifiers (at time of writing,
/// `true | false | if | then | else | in | is | like | has`).
//
// For now, internally, `Id`s are just owned `SmolString`s.
#[derive(Serialize, Debug, PartialEq, Eq, Clone, Hash, PartialOrd, Ord)]
pub struct Id(SmolStr);
impl Id {
/// Create a new `Id` from a `String`, where it is the caller's
/// responsibility to ensure that the string is indeed a valid identifier.
///
/// When possible, callers should not use this, and instead use `s.parse()`,
/// which checks that `s` is a valid identifier, and returns a parse error
/// if not.
///
/// This method was created for the `From<cst::Ident> for Id` impl to use.
/// Since `parser::parse_ident()` implicitly uses that `From` impl itself,
/// if we tried to make that `From` impl go through `.parse()` like everyone
/// else, we'd get infinite recursion. And, we assert that `cst::Ident` is
/// always already checked to contain a valid identifier, otherwise it would
/// never have been created.
pub(crate) fn new_unchecked(s: impl Into<SmolStr>) -> Id {
Id(s.into())
}
/// Get the underlying string
pub fn into_smolstr(self) -> SmolStr {
self.0
}
/// Return if the `Id` is reserved (i.e., `__cedar`)
/// Note that it does not test if the `Id` string is a reserved keyword
/// as the parser already ensures that it is not
pub fn is_reserved(&self) -> bool {
self.as_ref() == RESERVED_ID
}
}
impl AsRef<str> for Id {
fn as_ref(&self) -> &str {
&self.0
}
}
impl std::fmt::Display for Id {
fn fmt(&self, f: &mut std::fmt::Formatter<'_>) -> std::fmt::Result {
write!(f, "{}", &self.0)
}
}
// allow `.parse()` on a string to make an `Id`
impl std::str::FromStr for Id {
type Err = ParseErrors;
fn from_str(s: &str) -> Result<Self, Self::Err> {
crate::parser::parse_ident(s)
}
}
impl FromNormalizedStr for Id {
fn describe_self() -> &'static str {
"Id"
}
}
/// An `Id` that is not equal to `__cedar`, as specified by RFC 52
#[derive(Serialize, Debug, PartialEq, Eq, Clone, Hash, PartialOrd, Ord)]
#[cfg_attr(feature = "wasm", derive(tsify::Tsify))]
#[cfg_attr(feature = "wasm", tsify(into_wasm_abi, from_wasm_abi))]
pub struct UnreservedId(#[cfg_attr(feature = "wasm", tsify(type = "string"))] pub(crate) Id);
impl From<UnreservedId> for Id {
fn from(value: UnreservedId) -> Self {
value.0
}
}
impl TryFrom<Id> for UnreservedId {
type Error = ReservedNameError;
fn try_from(value: Id) -> Result<Self, Self::Error> {
if value.is_reserved() {
Err(ReservedNameError(InternalName::unqualified_name(value)))
} else {
Ok(Self(value))
}
}
}
impl AsRef<Id> for UnreservedId {
fn as_ref(&self) -> &Id {
&self.0
}
}
impl AsRef<str> for UnreservedId {
fn as_ref(&self) -> &str {
self.0.as_ref()
}
}
impl std::fmt::Display for UnreservedId {
fn fmt(&self, f: &mut std::fmt::Formatter<'_>) -> std::fmt::Result {
self.0.fmt(f)
}
}
impl std::str::FromStr for UnreservedId {
type Err = ParseErrors;
fn from_str(s: &str) -> Result<Self, Self::Err> {
Id::from_str(s).and_then(|id| id.try_into().map_err(ParseErrors::singleton))
}
}
impl FromNormalizedStr for UnreservedId {
fn describe_self() -> &'static str {
"Unreserved Id"
}
}
impl UnreservedId {
/// Create an [`UnreservedId`] from an empty string
pub(crate) fn empty() -> Self {
// PANIC SAFETY: "" does not contain `__cedar`
#[allow(clippy::unwrap_used)]
Id("".into()).try_into().unwrap()
}
}
struct IdVisitor;
impl<'de> serde::de::Visitor<'de> for IdVisitor {
type Value = Id;
fn expecting(&self, formatter: &mut std::fmt::Formatter<'_>) -> std::fmt::Result {
formatter.write_str("a valid id")
}
fn visit_str<E>(self, value: &str) -> Result<Self::Value, E>
where
E: serde::de::Error,
{
Id::from_normalized_str(value)
.map_err(|err| serde::de::Error::custom(format!("invalid id `{value}`: {err}")))
}
}
/// Deserialize an `Id` using `from_normalized_str`.
/// This deserialization implementation is used in the JSON schema format.
impl<'de> Deserialize<'de> for Id {
fn deserialize<D>(deserializer: D) -> Result<Self, D::Error>
where
D: Deserializer<'de>,
{
deserializer.deserialize_str(IdVisitor)
}
}
/// Deserialize a [`UnreservedId`] using `from_normalized_str`
/// This deserialization implementation is used in the JSON schema format.
impl<'de> Deserialize<'de> for UnreservedId {
fn deserialize<D>(deserializer: D) -> Result<Self, D::Error>
where
D: Deserializer<'de>,
{
deserializer
.deserialize_str(IdVisitor)
.and_then(|n| n.try_into().map_err(serde::de::Error::custom))
}
}
#[cfg(feature = "arbitrary")]
impl<'a> arbitrary::Arbitrary<'a> for Id {
fn arbitrary(u: &mut arbitrary::Unstructured<'a>) -> arbitrary::Result<Self> {
// identifier syntax:
// IDENT := ['_''a'-'z''A'-'Z']['_''a'-'z''A'-'Z''0'-'9']* - RESERVED
// BOOL := 'true' | 'false'
// RESERVED := BOOL | 'if' | 'then' | 'else' | 'in' | 'is' | 'like' | 'has'
let construct_list = |s: &str| s.chars().collect::<Vec<char>>();
let list_concat = |s1: &[char], s2: &[char]| [s1, s2].concat();
// the set of the first character of an identifier
let head_letters = construct_list("ABCDEFGHIJKLMNOPQRSTUVWXYZabcdefghijklmnopqrstuvwxyz_");
// the set of the remaining characters of an identifier
let tail_letters = list_concat(&construct_list("0123456789"), &head_letters);
// identifier character count minus 1
let remaining_length = u.int_in_range(0..=16)?;
let mut cs = vec![*u.choose(&head_letters)?];
cs.extend(
(0..remaining_length)
.map(|_| u.choose(&tail_letters))
.collect::<Result<Vec<&char>, _>>()?,
);
let mut s: String = cs.into_iter().collect();
// Should the parsing fails, the string should be reserved word.
// Append a `_` to create a valid Id.
if crate::parser::parse_ident(&s).is_err() {
s.push('_');
}
Ok(Self::new_unchecked(s))
}
fn size_hint(depth: usize) -> (usize, Option<usize>) {
arbitrary::size_hint::and_all(&[
// for arbitrary length
<usize as arbitrary::Arbitrary>::size_hint(depth),
// for arbitrary choices
// we use the size hint of a vector of `u8` to get an underestimate of bytes required by the sequence of choices.
<Vec<u8> as arbitrary::Arbitrary>::size_hint(depth),
])
}
}
#[cfg(feature = "arbitrary")]
impl<'a> arbitrary::Arbitrary<'a> for UnreservedId {
fn arbitrary(u: &mut arbitrary::Unstructured<'a>) -> arbitrary::Result<Self> {
let id: Id = u.arbitrary()?;
match UnreservedId::try_from(id.clone()) {
Ok(id) => Ok(id),
Err(_) => {
// PANIC SAFETY: `___cedar` is a valid unreserved id
#[allow(clippy::unwrap_used)]
let new_id = format!("_{id}").parse().unwrap();
Ok(new_id)
}
}
}
fn size_hint(depth: usize) -> (usize, Option<usize>) {
<Id as arbitrary::Arbitrary>::size_hint(depth)
}
}
/// Like `Id`, except this specifically _can_ contain Cedar reserved identifiers.
/// (It still can't contain, for instance, spaces or characters like '+'.)
//
// For now, internally, `AnyId`s are just owned `SmolString`s.
#[derive(Serialize, Debug, PartialEq, Eq, Clone, Hash, PartialOrd, Ord)]
pub struct AnyId(SmolStr);
impl AnyId {
/// Create a new `AnyId` from a `String`, where it is the caller's
/// responsibility to ensure that the string is indeed a valid `AnyId`.
///
/// When possible, callers should not use this, and instead use `s.parse()`,
/// which checks that `s` is a valid `AnyId`, and returns a parse error
/// if not.
///
/// This method was created for the `From<cst::Ident> for AnyId` impl to use.
/// See notes on `Id::new_unchecked()`.
pub(crate) fn new_unchecked(s: impl Into<SmolStr>) -> AnyId {
AnyId(s.into())
}
/// Get the underlying string
pub fn into_smolstr(self) -> SmolStr {
self.0
}
}
struct AnyIdVisitor;
impl<'de> serde::de::Visitor<'de> for AnyIdVisitor {
type Value = AnyId;
fn expecting(&self, formatter: &mut std::fmt::Formatter<'_>) -> std::fmt::Result {
formatter.write_str("any id")
}
fn visit_str<E>(self, value: &str) -> Result<Self::Value, E>
where
E: serde::de::Error,
{
AnyId::from_normalized_str(value)
.map_err(|err| serde::de::Error::custom(format!("invalid id `{value}`: {err}")))
}
}
/// Deserialize an `AnyId` using `from_normalized_str`.
/// This deserialization implementation is used in the JSON policy format.
impl<'de> Deserialize<'de> for AnyId {
fn deserialize<D>(deserializer: D) -> Result<Self, D::Error>
where
D: Deserializer<'de>,
{
deserializer.deserialize_str(AnyIdVisitor)
}
}
impl AsRef<str> for AnyId {
fn as_ref(&self) -> &str {
&self.0
}
}
impl std::fmt::Display for AnyId {
fn fmt(&self, f: &mut std::fmt::Formatter<'_>) -> std::fmt::Result {
write!(f, "{}", &self.0)
}
}
// allow `.parse()` on a string to make an `AnyId`
impl std::str::FromStr for AnyId {
type Err = ParseErrors;
fn from_str(s: &str) -> Result<Self, Self::Err> {
crate::parser::parse_anyid(s)
}
}
impl FromNormalizedStr for AnyId {
fn describe_self() -> &'static str {
"AnyId"
}
}
#[cfg(feature = "arbitrary")]
impl<'a> arbitrary::Arbitrary<'a> for AnyId {
fn arbitrary(u: &mut arbitrary::Unstructured<'a>) -> arbitrary::Result<Self> {
// AnyId syntax:
// ['_''a'-'z''A'-'Z']['_''a'-'z''A'-'Z''0'-'9']*
let construct_list = |s: &str| s.chars().collect::<Vec<char>>();
let list_concat = |s1: &[char], s2: &[char]| [s1, s2].concat();
// the set of the first character of an AnyId
let head_letters = construct_list("ABCDEFGHIJKLMNOPQRSTUVWXYZabcdefghijklmnopqrstuvwxyz_");
// the set of the remaining characters of an AnyId
let tail_letters = list_concat(&construct_list("0123456789"), &head_letters);
// identifier character count minus 1
let remaining_length = u.int_in_range(0..=16)?;
let mut cs = vec![*u.choose(&head_letters)?];
cs.extend(
(0..remaining_length)
.map(|_| u.choose(&tail_letters))
.collect::<Result<Vec<&char>, _>>()?,
);
let s: String = cs.into_iter().collect();
debug_assert!(
crate::parser::parse_anyid(&s).is_ok(),
"all strings constructed this way should be valid AnyIds, but this one is not: {s:?}"
);
Ok(Self::new_unchecked(s))
}
fn size_hint(depth: usize) -> (usize, Option<usize>) {
arbitrary::size_hint::and_all(&[
// for arbitrary length
<usize as arbitrary::Arbitrary>::size_hint(depth),
// for arbitrary choices
// we use the size hint of a vector of `u8` to get an underestimate of bytes required by the sequence of choices.
<Vec<u8> as arbitrary::Arbitrary>::size_hint(depth),
])
}
}
// PANIC SAFETY: unit-test code
#[allow(clippy::panic)]
#[cfg(test)]
mod test {
use super::*;
#[test]
fn normalized_id() {
Id::from_normalized_str("foo").expect("should be OK");
Id::from_normalized_str("foo::bar").expect_err("shouldn't be OK");
Id::from_normalized_str(r#"foo::"bar""#).expect_err("shouldn't be OK");
Id::from_normalized_str(" foo").expect_err("shouldn't be OK");
Id::from_normalized_str("foo ").expect_err("shouldn't be OK");
Id::from_normalized_str("foo\n").expect_err("shouldn't be OK");
Id::from_normalized_str("foo//comment").expect_err("shouldn't be OK");
}
}