1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341 342 343 344 345 346 347 348 349 350 351 352 353 354 355 356 357 358 359 360 361 362 363 364 365 366 367 368 369 370 371 372 373 374 375 376 377 378 379 380 381 382 383 384 385 386 387 388 389 390 391 392 393 394 395 396 397 398 399 400 401 402 403 404 405 406 407 408 409 410 411 412 413 414 415 416 417 418 419 420 421 422 423 424 425 426 427 428 429 430 431 432 433 434 435 436 437 438 439 440 441 442 443 444 445 446 447 448 449 450 451 452 453 454 455 456 457 458 459 460 461 462 463 464 465 466 467 468 469 470 471 472 473 474 475 476 477 478 479 480 481 482 483 484 485 486 487 488 489 490 491 492 493 494 495 496 497 498 499 500 501
/*
* Copyright 2022-2023 Amazon.com, Inc. or its affiliates. All Rights Reserved.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* https://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/
//! Validator for Cedar policies
#![forbid(unsafe_code)]
use cedar_policy_core::ast::{Policy, PolicySet, Template};
use serde::Serialize;
use std::collections::HashSet;
mod err;
pub use err::*;
mod coreschema;
pub use coreschema::*;
mod expr_iterator;
mod extension_schema;
mod extensions;
mod fuzzy_match;
mod validation_result;
pub use validation_result::*;
mod rbac;
mod schema;
pub use schema::*;
mod schema_file_format;
pub use schema_file_format::*;
mod str_checks;
pub use str_checks::{confusable_string_checks, ValidationWarning, ValidationWarningKind};
mod type_error;
pub use type_error::*;
pub mod human_schema;
pub mod typecheck;
use typecheck::Typechecker;
pub mod types;
/// Used to select how a policy will be validated.
#[derive(Default, Eq, PartialEq, Copy, Clone, Debug, Serialize)]
pub enum ValidationMode {
#[default]
Strict,
Permissive,
#[cfg(feature = "partial-validate")]
Partial,
}
impl ValidationMode {
/// Does this mode use partial validation. We could conceivably have a
/// strict/partial validation mode.
fn is_partial(self) -> bool {
match self {
ValidationMode::Strict | ValidationMode::Permissive => false,
#[cfg(feature = "partial-validate")]
ValidationMode::Partial => true,
}
}
/// Does this mode apply strict validation rules.
fn is_strict(self) -> bool {
match self {
ValidationMode::Strict => true,
ValidationMode::Permissive => false,
#[cfg(feature = "partial-validate")]
ValidationMode::Partial => false,
}
}
}
/// Structure containing the context needed for policy validation. This is
/// currently only the `EntityType`s and `ActionType`s from a single schema.
#[derive(Debug)]
pub struct Validator {
schema: ValidatorSchema,
}
impl Validator {
/// Construct a new Validator from a schema file.
pub fn new(schema: ValidatorSchema) -> Validator {
Self { schema }
}
/// Validate all templates, links, and static policies in a policy set.
/// Return an iterator of policy notes associated with each policy id.
pub fn validate<'a>(
&'a self,
policies: &'a PolicySet,
mode: ValidationMode,
) -> ValidationResult<'a> {
let template_and_static_policy_errs = policies
.all_templates()
.flat_map(|p| self.validate_policy(p, mode));
let link_errs = policies
.policies()
.filter_map(|p| self.validate_slots(p, mode))
.flatten();
ValidationResult::new(
template_and_static_policy_errs.chain(link_errs),
confusable_string_checks(policies.all_templates()),
)
}
/// Run all validations against a single static policy or template (note
/// that Core `Template` includes static policies as well), gathering all
/// validation notes together in the returned iterator.
fn validate_policy<'a>(
&'a self,
p: &'a Template,
mode: ValidationMode,
) -> impl Iterator<Item = ValidationError> + 'a {
if mode.is_partial() {
// We skip `validate_entity_types`, `validate_action_ids`, and
// `validate_action_application` passes for partial schema
// validation because there may be arbitrary extra entity types and
// actions, so we can never claim that one doesn't exist.
None
} else {
Some(
self.validate_entity_types(p)
.chain(self.validate_action_ids(p))
// We could usefully update this pass to apply to partial
// schema if it only failed when there is a known action
// applied to known principal/resource entity types that are
// not in its `appliesTo`.
.chain(self.validate_action_application(
p.principal_constraint(),
p.action_constraint(),
p.resource_constraint(),
))
.map(move |note| ValidationError::with_policy_id(p.id(), None, note)),
)
}
.into_iter()
.flatten()
.chain(self.typecheck_policy(p, mode))
}
/// Run relevant validations against a single template-linked policy,
/// gathering all validation notes together in the returned iterator.
fn validate_slots<'a>(
&'a self,
p: &'a Policy,
mode: ValidationMode,
) -> Option<impl Iterator<Item = ValidationError> + 'a> {
// Ignore static policies since they are already handled by `validate_policy`
if p.is_static() {
return None;
}
// In partial validation, there may be arbitrary extra entity types and
// actions, so we can never claim that one doesn't exist or that the
// action application is invalid.
if mode.is_partial() {
return None;
}
// For template-linked policies `Policy::principal_constraint()` and
// `Policy::resource_constraint()` return a copy of the constraint with
// the slot filled by the appropriate value.
Some(
self.validate_entity_types_in_slots(p.env())
.chain(self.validate_action_application(
&p.principal_constraint(),
p.action_constraint(),
&p.resource_constraint(),
))
.map(move |note| ValidationError::with_policy_id(p.id(), None, note)),
)
}
/// Construct a Typechecker instance and use it to detect any type errors in
/// the argument static policy or template (note that Core `Template`
/// includes static policies as well) in the context of the schema for this
/// validator. Any detected type errors are wrapped and returned as
/// `ValidationErrorKind`s.
fn typecheck_policy<'a>(
&'a self,
t: &'a Template,
mode: ValidationMode,
) -> impl Iterator<Item = ValidationError> + 'a {
let typecheck = Typechecker::new(&self.schema, mode);
let mut type_errors = HashSet::new();
typecheck.typecheck_policy(t, &mut type_errors);
type_errors.into_iter().map(|type_error| {
let (kind, location) = type_error.kind_and_location();
ValidationError::with_policy_id(t.id(), location, ValidationErrorKind::type_error(kind))
})
}
}
#[cfg(test)]
mod test {
use std::collections::HashMap;
use crate::types::Type;
use super::*;
use cedar_policy_core::{
ast::{self, Expr},
parser,
};
#[test]
fn top_level_validate() -> Result<()> {
let mut set = PolicySet::new();
let foo_type = "foo_type";
let bar_type = "bar_type";
let action_name = "action";
let schema_file = NamespaceDefinition::new(
[
(
foo_type.into(),
EntityType {
member_of_types: vec![],
shape: AttributesOrContext::default(),
},
),
(
bar_type.into(),
EntityType {
member_of_types: vec![],
shape: AttributesOrContext::default(),
},
),
],
[(
action_name.into(),
ActionType {
applies_to: Some(ApplySpec {
resource_types: None,
principal_types: None,
context: AttributesOrContext::default(),
}),
member_of: None,
attributes: None,
},
)],
);
let schema = schema_file.try_into().unwrap();
let validator = Validator::new(schema);
let policy_a_src = r#"permit(principal in foo_type::"a", action == Action::"actin", resource == bar_type::"b");"#;
let policy_a = parser::parse_policy(Some("pola".to_string()), policy_a_src)
.expect("Test Policy Should Parse");
set.add_static(policy_a.clone())
.expect("Policy already present in PolicySet");
let policy_b_src = r#"permit(principal in foo_tye::"a", action == Action::"action", resource == br_type::"b");"#;
let policy_b = parser::parse_policy(Some("polb".to_string()), policy_b_src)
.expect("Test Policy Should Parse");
set.add_static(policy_b.clone())
.expect("Policy already present in PolicySet");
let result = validator.validate(&set, ValidationMode::default());
let principal_err = ValidationError::with_policy_id(
policy_b.id(),
None,
ValidationErrorKind::unrecognized_entity_type(
"foo_tye".to_string(),
Some("foo_type".to_string()),
),
);
let resource_err = ValidationError::with_policy_id(
policy_b.id(),
None,
ValidationErrorKind::unrecognized_entity_type(
"br_type".to_string(),
Some("bar_type".to_string()),
),
);
let action_err = ValidationError::with_policy_id(
policy_a.id(),
None,
ValidationErrorKind::unrecognized_action_id(
"Action::\"actin\"".to_string(),
Some("Action::\"action\"".to_string()),
),
);
assert!(!result.validation_passed());
assert!(result.validation_errors().any(|x| x == &principal_err));
assert!(result.validation_errors().any(|x| x == &resource_err));
assert!(result.validation_errors().any(|x| x == &action_err));
Ok(())
}
#[test]
fn top_level_validate_with_instantiations() -> Result<()> {
let mut set = PolicySet::new();
let schema: ValidatorSchema = serde_json::from_str::<SchemaFragment>(
r#"
{
"some_namespace": {
"entityTypes": {
"User": {
"shape": {
"type": "Record",
"attributes": {
"department": {
"type": "String"
},
"jobLevel": {
"type": "Long"
}
}
},
"memberOfTypes": [
"UserGroup"
]
},
"UserGroup": {},
"Photo" : {}
},
"actions": {
"view": {
"appliesTo": {
"resourceTypes": [
"Photo"
],
"principalTypes": [
"User"
]
}
}
}
}
}
"#,
)
.expect("Schema parse error.")
.try_into()
.expect("Expected valid schema.");
let validator = Validator::new(schema);
let t = parser::parse_policy_template(
Some("template".to_string()),
r#"permit(principal == some_namespace::User::"Alice", action, resource in ?resource);"#,
)
.expect("Parse Error");
set.add_template(t)
.expect("Template already present in PolicySet");
// the template is valid by itself
let result = validator.validate(&set, ValidationMode::default());
assert_eq!(
result.validation_errors().collect::<Vec<_>>(),
Vec::<&ValidationError>::new()
);
// a valid instantiation is valid
let mut values = HashMap::new();
values.insert(
ast::SlotId::resource(),
ast::EntityUID::from_components(
"some_namespace::Photo".parse().unwrap(),
ast::Eid::new("foo"),
),
);
set.link(
ast::PolicyID::from_string("template"),
ast::PolicyID::from_string("link1"),
values,
)
.expect("Linking failed!");
let result = validator.validate(&set, ValidationMode::default());
assert!(result.validation_passed());
// an invalid instantiation results in an error
let mut values = HashMap::new();
values.insert(
ast::SlotId::resource(),
ast::EntityUID::from_components(
"some_namespace::Undefined".parse().unwrap(),
ast::Eid::new("foo"),
),
);
set.link(
ast::PolicyID::from_string("template"),
ast::PolicyID::from_string("link2"),
values,
)
.expect("Linking failed!");
let result = validator.validate(&set, ValidationMode::default());
assert!(!result.validation_passed());
assert_eq!(result.validation_errors().count(), 2);
let id = ast::PolicyID::from_string("link2");
let undefined_err = ValidationError::with_policy_id(
&id,
None,
ValidationErrorKind::unrecognized_entity_type(
"some_namespace::Undefined".to_string(),
Some("some_namespace::User".to_string()),
),
);
let invalid_action_err = ValidationError::with_policy_id(
&id,
None,
ValidationErrorKind::invalid_action_application(false, false),
);
assert!(result.validation_errors().any(|x| x == &undefined_err));
assert!(result.validation_errors().any(|x| x == &invalid_action_err));
// this is also an invalid instantiation (not a valid resource type for any action in the schema)
let mut values = HashMap::new();
values.insert(
ast::SlotId::resource(),
ast::EntityUID::from_components(
"some_namespace::User".parse().unwrap(),
ast::Eid::new("foo"),
),
);
set.link(
ast::PolicyID::from_string("template"),
ast::PolicyID::from_string("link3"),
values,
)
.expect("Linking failed!");
let result = validator.validate(&set, ValidationMode::default());
assert!(!result.validation_passed());
// `result` contains the two prior error messages plus one new one
assert_eq!(result.validation_errors().count(), 3);
let id = ast::PolicyID::from_string("link3");
let invalid_action_err = ValidationError::with_policy_id(
&id,
None,
ValidationErrorKind::invalid_action_application(false, false),
);
assert!(result.validation_errors().any(|x| x == &invalid_action_err));
Ok(())
}
#[test]
fn validate_finds_warning_and_error() {
let schema: ValidatorSchema = serde_json::from_str::<SchemaFragment>(
r#"
{
"": {
"entityTypes": {
"User": { }
},
"actions": {
"view": {
"appliesTo": {
"resourceTypes": [ "User" ],
"principalTypes": [ "User" ]
}
}
}
}
}
"#,
)
.expect("Schema parse error.")
.try_into()
.expect("Expected valid schema.");
let validator = Validator::new(schema);
let mut set = PolicySet::new();
let p = parser::parse_policy(
None,
r#"permit(principal == User::"һenry", action, resource) when {1 > true};"#,
)
.unwrap();
set.add_static(p).unwrap();
let result = validator.validate(&set, ValidationMode::default());
assert_eq!(
result
.validation_errors()
.map(|err| err.error_kind())
.collect::<Vec<_>>(),
vec![&ValidationErrorKind::type_error(
TypeError::expected_type(
Expr::val(1),
Type::primitive_long(),
Type::singleton_boolean(true),
None,
)
.kind
)]
);
assert_eq!(
result
.validation_warnings()
.map(|warn| warn.kind())
.collect::<Vec<_>>(),
vec![&ValidationWarningKind::MixedScriptIdentifier(
"һenry".into()
)]
);
}
}