1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253
// Licensed to the Apache Software Foundation (ASF) under one
// or more contributor license agreements. See the NOTICE file
// distributed with this work for additional information
// regarding copyright ownership. The ASF licenses this file
// to you under the Apache License, Version 2.0 (the
// "License"); you may not use this file except in compliance
// with the License. You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to in writing,
// software distributed under the License is distributed on an
// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
// KIND, either express or implied. See the License for the
// specific language governing permissions and limitations
// under the License.
//! Manages files generated during query execution, files are
//! hashed among the directories listed in RuntimeConfig::local_dirs.
use datafusion_common::{DataFusionError, Result};
use log::debug;
use parking_lot::Mutex;
use rand::{thread_rng, Rng};
use std::path::PathBuf;
use std::sync::Arc;
use tempfile::{Builder, NamedTempFile, TempDir};
/// Configuration for temporary disk access
#[derive(Debug, Clone)]
pub enum DiskManagerConfig {
/// Use the provided [DiskManager] instance
Existing(Arc<DiskManager>),
/// Create a new [DiskManager] that creates temporary files within
/// a temporary directory chosen by the OS
NewOs,
/// Create a new [DiskManager] that creates temporary files within
/// the specified directories
NewSpecified(Vec<PathBuf>),
/// Disable disk manager, attempts to create temporary files will error
Disabled,
}
impl Default for DiskManagerConfig {
fn default() -> Self {
Self::NewOs
}
}
impl DiskManagerConfig {
/// Create temporary files in a temporary directory chosen by the OS
pub fn new() -> Self {
Self::default()
}
/// Create temporary files using the provided disk manager
pub fn new_existing(existing: Arc<DiskManager>) -> Self {
Self::Existing(existing)
}
/// Create temporary files in the specified directories
pub fn new_specified(paths: Vec<PathBuf>) -> Self {
Self::NewSpecified(paths)
}
}
/// Manages files generated during query execution, e.g. spill files generated
/// while processing dataset larger than available memory.
#[derive(Debug)]
pub struct DiskManager {
/// TempDirs to put temporary files in.
///
/// If `Some(vec![])` a new OS specified temporary directory will be created
/// If `None` an error will be returned (configured not to spill)
local_dirs: Mutex<Option<Vec<TempDir>>>,
}
impl DiskManager {
/// Create a DiskManager given the configuration
pub fn try_new(config: DiskManagerConfig) -> Result<Arc<Self>> {
match config {
DiskManagerConfig::Existing(manager) => Ok(manager),
DiskManagerConfig::NewOs => Ok(Arc::new(Self {
local_dirs: Mutex::new(Some(vec![])),
})),
DiskManagerConfig::NewSpecified(conf_dirs) => {
let local_dirs = create_local_dirs(conf_dirs)?;
debug!(
"Created local dirs {:?} as DataFusion working directory",
local_dirs
);
Ok(Arc::new(Self {
local_dirs: Mutex::new(Some(local_dirs)),
}))
}
DiskManagerConfig::Disabled => Ok(Arc::new(Self {
local_dirs: Mutex::new(None),
})),
}
}
/// Return true if this disk manager supports creating temporary
/// files. If this returns false, any call to `create_tmp_file`
/// will error.
pub fn tmp_files_enabled(&self) -> bool {
self.local_dirs.lock().is_some()
}
/// Return a temporary file from a randomized choice in the configured locations
///
/// If the file can not be created for some reason, returns an
/// error message referencing the request description
pub fn create_tmp_file(&self, request_description: &str) -> Result<NamedTempFile> {
let mut guard = self.local_dirs.lock();
let local_dirs = guard.as_mut().ok_or_else(|| {
DataFusionError::ResourcesExhausted(format!(
"Memory Exhausted while {request_description} (DiskManager is disabled)"
))
})?;
// Create a temporary directory if needed
if local_dirs.is_empty() {
let tempdir = tempfile::tempdir().map_err(DataFusionError::IoError)?;
debug!(
"Created directory '{:?}' as DataFusion tempfile directory for {}",
tempdir.path().to_string_lossy(),
request_description,
);
local_dirs.push(tempdir);
}
let dir_index = thread_rng().gen_range(0..local_dirs.len());
Builder::new()
.tempfile_in(&local_dirs[dir_index])
.map_err(DataFusionError::IoError)
}
}
/// Setup local dirs by creating one new dir in each of the given dirs
fn create_local_dirs(local_dirs: Vec<PathBuf>) -> Result<Vec<TempDir>> {
local_dirs
.iter()
.map(|root| {
if !std::path::Path::new(root).exists() {
std::fs::create_dir(root)?;
}
Builder::new()
.prefix("datafusion-")
.tempdir_in(root)
.map_err(DataFusionError::IoError)
})
.collect()
}
#[cfg(test)]
mod tests {
use std::path::Path;
use super::*;
use tempfile::TempDir;
#[test]
fn lazy_temp_dir_creation() -> Result<()> {
// A default configuration should not create temp files until requested
let config = DiskManagerConfig::new();
let dm = DiskManager::try_new(config)?;
assert_eq!(0, local_dir_snapshot(&dm).len());
// can still create a tempfile however:
let actual = dm.create_tmp_file("Testing")?;
// Now the tempdir has been created on demand
assert_eq!(1, local_dir_snapshot(&dm).len());
// the returned tempfile file should be in the temp directory
let local_dirs = local_dir_snapshot(&dm);
assert_path_in_dirs(actual.path(), local_dirs.iter().map(|p| p.as_path()));
Ok(())
}
fn local_dir_snapshot(dm: &DiskManager) -> Vec<PathBuf> {
dm.local_dirs
.lock()
.iter()
.flatten()
.map(|p| p.path().into())
.collect()
}
#[test]
fn file_in_right_dir() -> Result<()> {
let local_dir1 = TempDir::new()?;
let local_dir2 = TempDir::new()?;
let local_dir3 = TempDir::new()?;
let local_dirs = vec![local_dir1.path(), local_dir2.path(), local_dir3.path()];
let config = DiskManagerConfig::new_specified(
local_dirs.iter().map(|p| p.into()).collect(),
);
let dm = DiskManager::try_new(config)?;
assert!(dm.tmp_files_enabled());
let actual = dm.create_tmp_file("Testing")?;
// the file should be in one of the specified local directories
assert_path_in_dirs(actual.path(), local_dirs.into_iter());
Ok(())
}
#[test]
fn test_disabled_disk_manager() {
let config = DiskManagerConfig::Disabled;
let manager = DiskManager::try_new(config).unwrap();
assert!(!manager.tmp_files_enabled());
assert_eq!(
manager.create_tmp_file("Testing").unwrap_err().strip_backtrace(),
"Resources exhausted: Memory Exhausted while Testing (DiskManager is disabled)",
)
}
#[test]
fn test_disk_manager_create_spill_folder() {
let config = DiskManagerConfig::new_specified(vec!["DOESNT_EXIST".into()]);
DiskManager::try_new(config)
.unwrap()
.create_tmp_file("Testing")
.unwrap();
}
/// Asserts that `file_path` is found anywhere in any of `dir` directories
fn assert_path_in_dirs<'a>(
file_path: &'a Path,
dirs: impl Iterator<Item = &'a Path>,
) {
let dirs: Vec<&Path> = dirs.collect();
let found = dirs.iter().any(|dir_path| {
file_path
.ancestors()
.any(|candidate_path| *dir_path == candidate_path)
});
assert!(found, "Can't find {file_path:?} in dirs: {dirs:?}");
}
}