use crate::codec::{Cookie, ErrorCode, Message, Namespace, NewRegistration, Registration, Ttl};
use crate::{MAX_TTL, MIN_TTL};
use bimap::BiMap;
use futures::future::BoxFuture;
use futures::stream::FuturesUnordered;
use futures::{FutureExt, StreamExt};
use libp2p_core::{Endpoint, Multiaddr};
use libp2p_identity::PeerId;
use libp2p_request_response::ProtocolSupport;
use libp2p_swarm::behaviour::FromSwarm;
use libp2p_swarm::{
ConnectionDenied, ConnectionId, NetworkBehaviour, THandler, THandlerInEvent, THandlerOutEvent,
ToSwarm,
};
use std::collections::{HashMap, HashSet};
use std::iter;
use std::iter::FromIterator;
use std::task::{ready, Context, Poll};
use std::time::Duration;
pub struct Behaviour {
inner: libp2p_request_response::Behaviour<crate::codec::Codec>,
registrations: Registrations,
}
pub struct Config {
min_ttl: Ttl,
max_ttl: Ttl,
}
impl Config {
pub fn with_min_ttl(mut self, min_ttl: Ttl) -> Self {
self.min_ttl = min_ttl;
self
}
pub fn with_max_ttl(mut self, max_ttl: Ttl) -> Self {
self.max_ttl = max_ttl;
self
}
}
impl Default for Config {
fn default() -> Self {
Self {
min_ttl: MIN_TTL,
max_ttl: MAX_TTL,
}
}
}
impl Behaviour {
pub fn new(config: Config) -> Self {
Self {
inner: libp2p_request_response::Behaviour::with_codec(
crate::codec::Codec::default(),
iter::once((crate::PROTOCOL_IDENT, ProtocolSupport::Inbound)),
libp2p_request_response::Config::default(),
),
registrations: Registrations::with_config(config),
}
}
}
#[derive(Debug)]
#[allow(clippy::large_enum_variant)]
pub enum Event {
DiscoverServed {
enquirer: PeerId,
registrations: Vec<Registration>,
},
DiscoverNotServed { enquirer: PeerId, error: ErrorCode },
PeerRegistered {
peer: PeerId,
registration: Registration,
},
PeerNotRegistered {
peer: PeerId,
namespace: Namespace,
error: ErrorCode,
},
PeerUnregistered { peer: PeerId, namespace: Namespace },
RegistrationExpired(Registration),
}
impl NetworkBehaviour for Behaviour {
type ConnectionHandler = <libp2p_request_response::Behaviour<
crate::codec::Codec,
> as NetworkBehaviour>::ConnectionHandler;
type ToSwarm = Event;
fn handle_established_inbound_connection(
&mut self,
connection_id: ConnectionId,
peer: PeerId,
local_addr: &Multiaddr,
remote_addr: &Multiaddr,
) -> Result<THandler<Self>, ConnectionDenied> {
self.inner.handle_established_inbound_connection(
connection_id,
peer,
local_addr,
remote_addr,
)
}
fn handle_established_outbound_connection(
&mut self,
connection_id: ConnectionId,
peer: PeerId,
addr: &Multiaddr,
role_override: Endpoint,
) -> Result<THandler<Self>, ConnectionDenied> {
self.inner
.handle_established_outbound_connection(connection_id, peer, addr, role_override)
}
fn on_connection_handler_event(
&mut self,
peer_id: PeerId,
connection: ConnectionId,
event: THandlerOutEvent<Self>,
) {
self.inner
.on_connection_handler_event(peer_id, connection, event);
}
fn poll(
&mut self,
cx: &mut Context<'_>,
) -> Poll<ToSwarm<Self::ToSwarm, THandlerInEvent<Self>>> {
if let Poll::Ready(ExpiredRegistration(registration)) = self.registrations.poll(cx) {
return Poll::Ready(ToSwarm::GenerateEvent(Event::RegistrationExpired(
registration,
)));
}
loop {
if let Poll::Ready(to_swarm) = self.inner.poll(cx) {
match to_swarm {
ToSwarm::GenerateEvent(libp2p_request_response::Event::Message {
peer: peer_id,
message:
libp2p_request_response::Message::Request {
request, channel, ..
},
}) => {
if let Some((event, response)) =
handle_request(peer_id, request, &mut self.registrations)
{
if let Some(resp) = response {
self.inner
.send_response(channel, resp)
.expect("Send response");
}
return Poll::Ready(ToSwarm::GenerateEvent(event));
}
continue;
}
ToSwarm::GenerateEvent(libp2p_request_response::Event::InboundFailure {
peer,
request_id,
error,
}) => {
tracing::warn!(
%peer,
request=%request_id,
"Inbound request with peer failed: {error}"
);
continue;
}
ToSwarm::GenerateEvent(libp2p_request_response::Event::ResponseSent {
..
})
| ToSwarm::GenerateEvent(libp2p_request_response::Event::Message {
peer: _,
message: libp2p_request_response::Message::Response { .. },
})
| ToSwarm::GenerateEvent(libp2p_request_response::Event::OutboundFailure {
..
}) => {
continue;
}
ToSwarm::Dial { .. }
| ToSwarm::ListenOn { .. }
| ToSwarm::RemoveListener { .. }
| ToSwarm::NotifyHandler { .. }
| ToSwarm::NewExternalAddrCandidate(_)
| ToSwarm::ExternalAddrConfirmed(_)
| ToSwarm::ExternalAddrExpired(_)
| ToSwarm::CloseConnection { .. } => {
let new_to_swarm = to_swarm
.map_out(|_| unreachable!("we manually map `GenerateEvent` variants"));
return Poll::Ready(new_to_swarm);
}
_ => {}
};
}
return Poll::Pending;
}
}
fn on_swarm_event(&mut self, event: FromSwarm) {
self.inner.on_swarm_event(event);
}
}
fn handle_request(
peer_id: PeerId,
message: Message,
registrations: &mut Registrations,
) -> Option<(Event, Option<Message>)> {
match message {
Message::Register(registration) => {
if registration.record.peer_id() != peer_id {
let error = ErrorCode::NotAuthorized;
let event = Event::PeerNotRegistered {
peer: peer_id,
namespace: registration.namespace,
error,
};
return Some((event, Some(Message::RegisterResponse(Err(error)))));
}
let namespace = registration.namespace.clone();
match registrations.add(registration) {
Ok(registration) => {
let response = Message::RegisterResponse(Ok(registration.ttl));
let event = Event::PeerRegistered {
peer: peer_id,
registration,
};
Some((event, Some(response)))
}
Err(TtlOutOfRange::TooLong { .. }) | Err(TtlOutOfRange::TooShort { .. }) => {
let error = ErrorCode::InvalidTtl;
let response = Message::RegisterResponse(Err(error));
let event = Event::PeerNotRegistered {
peer: peer_id,
namespace,
error,
};
Some((event, Some(response)))
}
}
}
Message::Unregister(namespace) => {
registrations.remove(namespace.clone(), peer_id);
let event = Event::PeerUnregistered {
peer: peer_id,
namespace,
};
Some((event, None))
}
Message::Discover {
namespace,
cookie,
limit,
} => match registrations.get(namespace, cookie, limit) {
Ok((registrations, cookie)) => {
let discovered = registrations.cloned().collect::<Vec<_>>();
let response = Message::DiscoverResponse(Ok((discovered.clone(), cookie)));
let event = Event::DiscoverServed {
enquirer: peer_id,
registrations: discovered,
};
Some((event, Some(response)))
}
Err(_) => {
let error = ErrorCode::InvalidCookie;
let response = Message::DiscoverResponse(Err(error));
let event = Event::DiscoverNotServed {
enquirer: peer_id,
error,
};
Some((event, Some(response)))
}
},
Message::RegisterResponse(_) => None,
Message::DiscoverResponse(_) => None,
}
}
#[derive(Debug, Eq, PartialEq, Hash, Copy, Clone)]
struct RegistrationId(u64);
impl RegistrationId {
fn new() -> Self {
Self(rand::random())
}
}
#[derive(Debug, PartialEq)]
struct ExpiredRegistration(Registration);
pub struct Registrations {
registrations_for_peer: BiMap<(PeerId, Namespace), RegistrationId>,
registrations: HashMap<RegistrationId, Registration>,
cookies: HashMap<Cookie, HashSet<RegistrationId>>,
min_ttl: Ttl,
max_ttl: Ttl,
next_expiry: FuturesUnordered<BoxFuture<'static, RegistrationId>>,
}
#[derive(Debug, thiserror::Error)]
pub enum TtlOutOfRange {
#[error("Requested TTL ({requested}s) is too long; max {bound}s")]
TooLong { bound: Ttl, requested: Ttl },
#[error("Requested TTL ({requested}s) is too short; min {bound}s")]
TooShort { bound: Ttl, requested: Ttl },
}
impl Default for Registrations {
fn default() -> Self {
Registrations::with_config(Config::default())
}
}
impl Registrations {
pub fn with_config(config: Config) -> Self {
Self {
registrations_for_peer: Default::default(),
registrations: Default::default(),
min_ttl: config.min_ttl,
max_ttl: config.max_ttl,
cookies: Default::default(),
next_expiry: FuturesUnordered::from_iter(vec![futures::future::pending().boxed()]),
}
}
pub fn add(
&mut self,
new_registration: NewRegistration,
) -> Result<Registration, TtlOutOfRange> {
let ttl = new_registration.effective_ttl();
if ttl > self.max_ttl {
return Err(TtlOutOfRange::TooLong {
bound: self.max_ttl,
requested: ttl,
});
}
if ttl < self.min_ttl {
return Err(TtlOutOfRange::TooShort {
bound: self.min_ttl,
requested: ttl,
});
}
let namespace = new_registration.namespace;
let registration_id = RegistrationId::new();
if let Some(old_registration) = self
.registrations_for_peer
.get_by_left(&(new_registration.record.peer_id(), namespace.clone()))
{
self.registrations.remove(old_registration);
}
self.registrations_for_peer.insert(
(new_registration.record.peer_id(), namespace.clone()),
registration_id,
);
let registration = Registration {
namespace,
record: new_registration.record,
ttl,
};
self.registrations
.insert(registration_id, registration.clone());
let next_expiry = futures_timer::Delay::new(Duration::from_secs(ttl))
.map(move |_| registration_id)
.boxed();
self.next_expiry.push(next_expiry);
Ok(registration)
}
pub fn remove(&mut self, namespace: Namespace, peer_id: PeerId) {
let reggo_to_remove = self
.registrations_for_peer
.remove_by_left(&(peer_id, namespace));
if let Some((_, reggo_to_remove)) = reggo_to_remove {
self.registrations.remove(®go_to_remove);
}
}
pub fn get(
&mut self,
discover_namespace: Option<Namespace>,
cookie: Option<Cookie>,
limit: Option<u64>,
) -> Result<(impl Iterator<Item = &Registration> + '_, Cookie), CookieNamespaceMismatch> {
let cookie_namespace = cookie.as_ref().and_then(|cookie| cookie.namespace());
match (discover_namespace.as_ref(), cookie_namespace) {
(None, Some(_)) => return Err(CookieNamespaceMismatch),
(Some(namespace), Some(cookie_namespace)) if namespace != cookie_namespace => {
return Err(CookieNamespaceMismatch)
}
_ => {}
}
let mut reggos_of_last_discover = cookie
.and_then(|cookie| self.cookies.get(&cookie))
.cloned()
.unwrap_or_default();
let ids = self
.registrations_for_peer
.iter()
.filter_map({
|((_, namespace), registration_id)| {
if reggos_of_last_discover.contains(registration_id) {
return None;
}
match discover_namespace.as_ref() {
Some(discover_namespace) if discover_namespace == namespace => {
Some(registration_id)
}
Some(_) => None,
None => Some(registration_id),
}
}
})
.take(limit.unwrap_or(u64::MAX) as usize)
.cloned()
.collect::<Vec<_>>();
reggos_of_last_discover.extend(&ids);
let new_cookie = discover_namespace
.map(Cookie::for_namespace)
.unwrap_or_else(Cookie::for_all_namespaces);
self.cookies
.insert(new_cookie.clone(), reggos_of_last_discover);
let regs = &self.registrations;
let registrations = ids
.into_iter()
.map(move |id| regs.get(&id).expect("bad internal data structure"));
Ok((registrations, new_cookie))
}
fn poll(&mut self, cx: &mut Context<'_>) -> Poll<ExpiredRegistration> {
loop {
let expired_registration = ready!(self.next_expiry.poll_next_unpin(cx)).expect(
"This stream should never finish because it is initialised with a pending future",
);
self.cookies.retain(|_, registrations| {
registrations.remove(&expired_registration);
!registrations.is_empty()
});
self.registrations_for_peer
.remove_by_right(&expired_registration);
match self.registrations.remove(&expired_registration) {
None => {
continue;
}
Some(registration) => {
return Poll::Ready(ExpiredRegistration(registration));
}
}
}
}
}
#[derive(Debug, thiserror::Error, Eq, PartialEq)]
#[error("The provided cookie is not valid for a DISCOVER request for the given namespace")]
pub struct CookieNamespaceMismatch;
#[cfg(test)]
mod tests {
use instant::SystemTime;
use std::option::Option::None;
use libp2p_core::PeerRecord;
use libp2p_identity as identity;
use super::*;
#[test]
fn given_cookie_from_discover_when_discover_again_then_only_get_diff() {
let mut registrations = Registrations::default();
registrations.add(new_dummy_registration("foo")).unwrap();
registrations.add(new_dummy_registration("foo")).unwrap();
let (initial_discover, cookie) = registrations.get(None, None, None).unwrap();
assert_eq!(initial_discover.count(), 2);
let (subsequent_discover, _) = registrations.get(None, Some(cookie), None).unwrap();
assert_eq!(subsequent_discover.count(), 0);
}
#[test]
fn given_registrations_when_discover_all_then_all_are_returned() {
let mut registrations = Registrations::default();
registrations.add(new_dummy_registration("foo")).unwrap();
registrations.add(new_dummy_registration("foo")).unwrap();
let (discover, _) = registrations.get(None, None, None).unwrap();
assert_eq!(discover.count(), 2);
}
#[test]
fn given_registrations_when_discover_only_for_specific_namespace_then_only_those_are_returned()
{
let mut registrations = Registrations::default();
registrations.add(new_dummy_registration("foo")).unwrap();
registrations.add(new_dummy_registration("bar")).unwrap();
let (discover, _) = registrations
.get(Some(Namespace::from_static("foo")), None, None)
.unwrap();
assert_eq!(
discover.map(|r| &r.namespace).collect::<Vec<_>>(),
vec!["foo"]
);
}
#[test]
fn given_reregistration_old_registration_is_discarded() {
let alice = identity::Keypair::generate_ed25519();
let mut registrations = Registrations::default();
registrations
.add(new_registration("foo", alice.clone(), None))
.unwrap();
registrations
.add(new_registration("foo", alice, None))
.unwrap();
let (discover, _) = registrations
.get(Some(Namespace::from_static("foo")), None, None)
.unwrap();
assert_eq!(
discover.map(|r| &r.namespace).collect::<Vec<_>>(),
vec!["foo"]
);
}
#[test]
fn given_cookie_from_2nd_discover_does_not_return_nodes_from_first_discover() {
let mut registrations = Registrations::default();
registrations.add(new_dummy_registration("foo")).unwrap();
registrations.add(new_dummy_registration("foo")).unwrap();
let (initial_discover, cookie1) = registrations.get(None, None, None).unwrap();
assert_eq!(initial_discover.count(), 2);
let (subsequent_discover, cookie2) = registrations.get(None, Some(cookie1), None).unwrap();
assert_eq!(subsequent_discover.count(), 0);
let (subsequent_discover, _) = registrations.get(None, Some(cookie2), None).unwrap();
assert_eq!(subsequent_discover.count(), 0);
}
#[test]
fn cookie_from_different_discover_request_is_not_valid() {
let mut registrations = Registrations::default();
registrations.add(new_dummy_registration("foo")).unwrap();
registrations.add(new_dummy_registration("bar")).unwrap();
let (_, foo_discover_cookie) = registrations
.get(Some(Namespace::from_static("foo")), None, None)
.unwrap();
let result = registrations.get(
Some(Namespace::from_static("bar")),
Some(foo_discover_cookie),
None,
);
assert!(matches!(result, Err(CookieNamespaceMismatch)))
}
#[tokio::test]
async fn given_two_registration_ttls_one_expires_one_lives() {
let mut registrations = Registrations::with_config(Config {
min_ttl: 0,
max_ttl: 4,
});
let start_time = SystemTime::now();
registrations
.add(new_dummy_registration_with_ttl("foo", 1))
.unwrap();
registrations
.add(new_dummy_registration_with_ttl("bar", 4))
.unwrap();
let event = registrations.next_event().await;
let elapsed = start_time.elapsed().unwrap();
assert!(elapsed.as_secs() >= 1);
assert!(elapsed.as_secs() < 2);
assert_eq!(event.0.namespace, Namespace::from_static("foo"));
{
let (mut discovered_foo, _) = registrations
.get(Some(Namespace::from_static("foo")), None, None)
.unwrap();
assert!(discovered_foo.next().is_none());
}
let (mut discovered_bar, _) = registrations
.get(Some(Namespace::from_static("bar")), None, None)
.unwrap();
assert!(discovered_bar.next().is_some());
}
#[tokio::test]
async fn given_peer_unregisters_before_expiry_do_not_emit_registration_expired() {
let mut registrations = Registrations::with_config(Config {
min_ttl: 1,
max_ttl: 10,
});
let dummy_registration = new_dummy_registration_with_ttl("foo", 2);
let namespace = dummy_registration.namespace.clone();
let peer_id = dummy_registration.record.peer_id();
registrations.add(dummy_registration).unwrap();
registrations.no_event_for(1).await;
registrations.remove(namespace, peer_id);
registrations.no_event_for(3).await
}
#[tokio::test]
async fn given_all_registrations_expired_then_successfully_handle_new_registration_and_expiry()
{
let mut registrations = Registrations::with_config(Config {
min_ttl: 0,
max_ttl: 10,
});
let dummy_registration = new_dummy_registration_with_ttl("foo", 1);
registrations.add(dummy_registration.clone()).unwrap();
let _ = registrations.next_event_in_at_most(2).await;
registrations.no_event_for(1).await;
registrations.add(dummy_registration).unwrap();
let _ = registrations.next_event_in_at_most(2).await;
}
#[tokio::test]
async fn cookies_are_cleaned_up_if_registrations_expire() {
let mut registrations = Registrations::with_config(Config {
min_ttl: 1,
max_ttl: 10,
});
registrations
.add(new_dummy_registration_with_ttl("foo", 2))
.unwrap();
let (_, _) = registrations.get(None, None, None).unwrap();
assert_eq!(registrations.cookies.len(), 1);
let _ = registrations.next_event_in_at_most(3).await;
assert_eq!(registrations.cookies.len(), 0);
}
#[test]
fn given_limit_discover_only_returns_n_results() {
let mut registrations = Registrations::default();
registrations.add(new_dummy_registration("foo")).unwrap();
registrations.add(new_dummy_registration("foo")).unwrap();
let (registrations, _) = registrations.get(None, None, Some(1)).unwrap();
assert_eq!(registrations.count(), 1);
}
#[test]
fn given_limit_cookie_can_be_used_for_pagination() {
let mut registrations = Registrations::default();
registrations.add(new_dummy_registration("foo")).unwrap();
registrations.add(new_dummy_registration("foo")).unwrap();
let (discover1, cookie) = registrations.get(None, None, Some(1)).unwrap();
assert_eq!(discover1.count(), 1);
let (discover2, _) = registrations.get(None, Some(cookie), None).unwrap();
assert_eq!(discover2.count(), 1);
}
fn new_dummy_registration(namespace: &'static str) -> NewRegistration {
let identity = identity::Keypair::generate_ed25519();
new_registration(namespace, identity, None)
}
fn new_dummy_registration_with_ttl(namespace: &'static str, ttl: Ttl) -> NewRegistration {
let identity = identity::Keypair::generate_ed25519();
new_registration(namespace, identity, Some(ttl))
}
fn new_registration(
namespace: &'static str,
identity: identity::Keypair,
ttl: Option<Ttl>,
) -> NewRegistration {
NewRegistration::new(
Namespace::from_static(namespace),
PeerRecord::new(&identity, vec!["/ip4/127.0.0.1/tcp/1234".parse().unwrap()]).unwrap(),
ttl,
)
}
impl Registrations {
async fn next_event(&mut self) -> ExpiredRegistration {
futures::future::poll_fn(|cx| self.poll(cx)).await
}
async fn no_event_for(&mut self, seconds: u64) {
tokio::time::timeout(Duration::from_secs(seconds), self.next_event())
.await
.unwrap_err();
}
async fn next_event_in_at_most(&mut self, seconds: u64) -> ExpiredRegistration {
tokio::time::timeout(Duration::from_secs(seconds), self.next_event())
.await
.unwrap()
}
}
}