1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
721
722
723
724
725
726
727
728
729
730
731
732
733
734
735
736
737
738
739
740
741
742
743
744
745
746
747
748
749
750
751
752
753
754
755
756
757
758
759
760
761
762
763
764
765
766
767
768
769
770
771
772
773
774
775
776
777
778
779
780
781
782
783
784
785
786
787
788
789
790
791
792
793
794
795
796
797
798
799
800
801
802
803
804
805
806
807
808
809
810
811
812
813
814
815
816
817
818
819
820
821
822
823
824
825
826
827
828
829
830
831
832
833
834
835
836
837
838
839
840
841
842
843
844
845
846
847
848
849
850
851
852
853
854
855
856
857
858
859
860
861
862
863
864
865
866
867
868
869
870
871
872
873
874
875
876
877
878
879
880
881
882
883
884
885
886
887
888
889
890
891
892
893
894
895
896
897
898
899
900
901
902
903
904
905
906
907
908
909
910
911
912
913
914
915
916
917
918
919
920
921
922
923
924
925
926
927
928
929
930
931
932
933
934
935
936
937
938
939
940
941
942
943
944
945
946
947
948
949
950
951
952
953
954
955
956
957
958
959
960
961
962
963
964
965
966
967
968
969
970
971
972
973
974
975
976
977
978
979
980
981
982
983
984
985
986
987
988
989
990
991
992
993
994
995
996
997
998
999
1000
1001
1002
1003
1004
1005
1006
1007
1008
1009
1010
1011
1012
1013
1014
1015
1016
1017
1018
1019
1020
1021
1022
1023
1024
1025
1026
1027
1028
1029
1030
1031
1032
1033
1034
1035
1036
1037
1038
1039
1040
1041
1042
1043
1044
1045
1046
1047
1048
1049
1050
1051
1052
1053
1054
1055
1056
1057
1058
1059
1060
1061
1062
1063
1064
1065
1066
1067
1068
1069
1070
1071
1072
1073
1074
1075
1076
1077
1078
1079
1080
1081
1082
1083
1084
1085
1086
1087
1088
1089
1090
1091
1092
1093
1094
1095
1096
1097
1098
1099
1100
1101
1102
1103
1104
1105
1106
1107
1108
1109
1110
1111
1112
1113
1114
1115
1116
1117
1118
1119
1120
1121
1122
1123
1124
1125
1126
1127
1128
1129
1130
1131
1132
1133
1134
1135
1136
1137
1138
1139
1140
1141
1142
1143
1144
1145
1146
1147
1148
1149
1150
1151
1152
1153
1154
1155
1156
1157
1158
1159
1160
1161
1162
1163
1164
1165
1166
1167
1168
1169
1170
1171
1172
1173
1174
1175
1176
1177
1178
1179
1180
1181
1182
1183
1184
1185
1186
1187
1188
1189
1190
1191
1192
1193
1194
1195
1196
1197
1198
1199
1200
1201
1202
1203
1204
1205
1206
1207
1208
1209
1210
1211
1212
1213
1214
1215
1216
1217
1218
1219
1220
1221
1222
1223
1224
1225
1226
1227
1228
1229
1230
1231
1232
1233
1234
1235
1236
1237
1238
1239
1240
1241
1242
1243
1244
1245
1246
1247
1248
1249
1250
1251
1252
1253
1254
1255
1256
1257
1258
1259
1260
1261
1262
1263
1264
1265
1266
1267
1268
1269
1270
1271
1272
1273
1274
1275
1276
1277
1278
1279
1280
1281
1282
1283
1284
1285
1286
1287
1288
1289
1290
1291
1292
1293
1294
1295
1296
1297
1298
1299
1300
1301
1302
1303
1304
1305
1306
1307
1308
1309
1310
1311
1312
1313
1314
1315
1316
1317
1318
1319
1320
1321
1322
1323
1324
1325
1326
1327
1328
1329
1330
1331
1332
1333
1334
1335
1336
1337
1338
1339
1340
1341
1342
1343
1344
1345
1346
1347
1348
1349
1350
1351
1352
1353
1354
1355
1356
1357
1358
1359
1360
1361
1362
1363
1364
//! Type-length-value structure definition and manipulation

use {
    crate::{error::TlvError, length::Length, variable_len_pack::VariableLenPack},
    bytemuck::Pod,
    solana_program::{account_info::AccountInfo, program_error::ProgramError},
    spl_discriminator::{ArrayDiscriminator, SplDiscriminate},
    spl_pod::bytemuck::{pod_from_bytes, pod_from_bytes_mut},
    std::{cmp::Ordering, mem::size_of},
};

/// Get the current TlvIndices from the current spot
const fn get_indices_unchecked(type_start: usize, value_repetition_number: usize) -> TlvIndices {
    let length_start = type_start.saturating_add(size_of::<ArrayDiscriminator>());
    let value_start = length_start.saturating_add(size_of::<Length>());
    TlvIndices {
        type_start,
        length_start,
        value_start,
        value_repetition_number,
    }
}

/// Internal helper struct for returning the indices of the type, length, and
/// value in a TLV entry
#[derive(Debug)]
struct TlvIndices {
    pub type_start: usize,
    pub length_start: usize,
    pub value_start: usize,
    pub value_repetition_number: usize,
}

fn get_indices(
    tlv_data: &[u8],
    value_discriminator: ArrayDiscriminator,
    init: bool,
    repetition_number: Option<usize>,
) -> Result<TlvIndices, ProgramError> {
    let mut current_repetition_number = 0;
    let mut start_index = 0;
    while start_index < tlv_data.len() {
        let tlv_indices = get_indices_unchecked(start_index, current_repetition_number);
        if tlv_data.len() < tlv_indices.value_start {
            return Err(ProgramError::InvalidAccountData);
        }
        let discriminator = ArrayDiscriminator::try_from(
            &tlv_data[tlv_indices.type_start..tlv_indices.length_start],
        )?;
        if discriminator == value_discriminator {
            if let Some(desired_repetition_number) = repetition_number {
                if current_repetition_number == desired_repetition_number {
                    return Ok(tlv_indices);
                }
            }
            current_repetition_number += 1;
        // got to an empty spot, init here, or error if we're searching, since
        // nothing is written after an Uninitialized spot
        } else if discriminator == ArrayDiscriminator::UNINITIALIZED {
            if init {
                return Ok(tlv_indices);
            } else {
                return Err(TlvError::TypeNotFound.into());
            }
        }
        let length =
            pod_from_bytes::<Length>(&tlv_data[tlv_indices.length_start..tlv_indices.value_start])?;
        let value_end_index = tlv_indices
            .value_start
            .saturating_add(usize::try_from(*length)?);
        start_index = value_end_index;
    }
    Err(ProgramError::InvalidAccountData)
}

// This function is doing two separate things at once, and would probably be
// better served by some custom iterator, but let's leave that for another day.
fn get_discriminators_and_end_index(
    tlv_data: &[u8],
) -> Result<(Vec<ArrayDiscriminator>, usize), ProgramError> {
    let mut discriminators = vec![];
    let mut start_index = 0;
    while start_index < tlv_data.len() {
        // This function is not concerned with repetitions, so we can just
        // arbitrarily pass `0` here
        let tlv_indices = get_indices_unchecked(start_index, 0);
        if tlv_data.len() < tlv_indices.length_start {
            // we got to the end, but there might be some uninitialized data after
            let remainder = &tlv_data[tlv_indices.type_start..];
            if remainder.iter().all(|&x| x == 0) {
                return Ok((discriminators, tlv_indices.type_start));
            } else {
                return Err(ProgramError::InvalidAccountData);
            }
        }
        let discriminator = ArrayDiscriminator::try_from(
            &tlv_data[tlv_indices.type_start..tlv_indices.length_start],
        )?;
        if discriminator == ArrayDiscriminator::UNINITIALIZED {
            return Ok((discriminators, tlv_indices.type_start));
        } else {
            if tlv_data.len() < tlv_indices.value_start {
                // not enough bytes to store the length, malformed
                return Err(ProgramError::InvalidAccountData);
            }
            discriminators.push(discriminator);
            let length = pod_from_bytes::<Length>(
                &tlv_data[tlv_indices.length_start..tlv_indices.value_start],
            )?;

            let value_end_index = tlv_indices
                .value_start
                .saturating_add(usize::try_from(*length)?);
            if value_end_index > tlv_data.len() {
                // value blows past the size of the slice, malformed
                return Err(ProgramError::InvalidAccountData);
            }
            start_index = value_end_index;
        }
    }
    Ok((discriminators, start_index))
}

fn get_bytes<V: SplDiscriminate>(
    tlv_data: &[u8],
    repetition_number: usize,
) -> Result<&[u8], ProgramError> {
    let TlvIndices {
        type_start: _,
        length_start,
        value_start,
        value_repetition_number: _,
    } = get_indices(
        tlv_data,
        V::SPL_DISCRIMINATOR,
        false,
        Some(repetition_number),
    )?;
    // get_indices has checked that tlv_data is long enough to include these
    // indices
    let length = pod_from_bytes::<Length>(&tlv_data[length_start..value_start])?;
    let value_end = value_start.saturating_add(usize::try_from(*length)?);
    if tlv_data.len() < value_end {
        return Err(ProgramError::InvalidAccountData);
    }
    Ok(&tlv_data[value_start..value_end])
}

/// Trait for all TLV state
///
/// Stores data as any number of type-length-value structures underneath, where:
///
///   * the "type" is an `ArrayDiscriminator`, 8 bytes
///   * the "length" is a `Length`, 4 bytes
///   * the "value" is a slab of "length" bytes
///
/// With this structure, it's possible to hold onto any number of entries with
/// unique discriminators, provided that the total underlying data has enough
/// bytes for every entry.
///
/// For example, if we have two distinct types, one which is an 8-byte array
/// of value `[0, 1, 0, 0, 0, 0, 0, 0]` and discriminator
/// `[1, 1, 1, 1, 1, 1, 1, 1]`, and another which is just a single `u8` of value
/// `4` with the discriminator `[2, 2, 2, 2, 2, 2, 2, 2]`, we can deserialize
/// this buffer as follows:
///
/// ```
/// use {
///     bytemuck::{Pod, Zeroable},
///     spl_discriminator::{ArrayDiscriminator, SplDiscriminate},
///     spl_type_length_value::state::{TlvState, TlvStateBorrowed, TlvStateMut},
/// };
/// #[repr(C)]
/// #[derive(Clone, Copy, Debug, Default, PartialEq, Pod, Zeroable)]
/// struct MyPodValue {
///     data: [u8; 8],
/// }
/// impl SplDiscriminate for MyPodValue {
///     const SPL_DISCRIMINATOR: ArrayDiscriminator = ArrayDiscriminator::new([1; ArrayDiscriminator::LENGTH]);
/// }
/// #[repr(C)]
/// #[derive(Clone, Copy, Debug, Default, PartialEq, Pod, Zeroable)]
/// struct MyOtherPodValue {
///     data: u8,
/// }
/// impl SplDiscriminate for MyOtherPodValue {
///     const SPL_DISCRIMINATOR: ArrayDiscriminator = ArrayDiscriminator::new([2; ArrayDiscriminator::LENGTH]);
/// }
/// let buffer = [
///   1, 1, 1, 1, 1, 1, 1, 1, // first type's discriminator
///   8, 0, 0, 0,             // first type's length
///   0, 1, 0, 0, 0, 0, 0, 0, // first type's value
///   2, 2, 2, 2, 2, 2, 2, 2, // second type's discriminator
///   1, 0, 0, 0,             // second type's length
///   4,                      // second type's value
/// ];
/// let state = TlvStateBorrowed::unpack(&buffer).unwrap();
/// let value = state.get_first_value::<MyPodValue>().unwrap();
/// assert_eq!(value.data, [0, 1, 0, 0, 0, 0, 0, 0]);
/// let value = state.get_first_value::<MyOtherPodValue>().unwrap();
/// assert_eq!(value.data, 4);
/// ```
///
/// See the README and tests for more examples on how to use these types.
pub trait TlvState {
    /// Get the full buffer containing all TLV data
    fn get_data(&self) -> &[u8];

    /// Unpack a portion of the TLV data as the desired Pod type for the entry
    /// number specified
    fn get_value_with_repetition<V: SplDiscriminate + Pod>(
        &self,
        repetition_number: usize,
    ) -> Result<&V, ProgramError> {
        let data = get_bytes::<V>(self.get_data(), repetition_number)?;
        pod_from_bytes::<V>(data)
    }

    /// Unpack a portion of the TLV data as the desired Pod type for the first
    /// entry found
    fn get_first_value<V: SplDiscriminate + Pod>(&self) -> Result<&V, ProgramError> {
        self.get_value_with_repetition::<V>(0)
    }

    /// Unpacks a portion of the TLV data as the desired variable-length type
    /// for the entry number specified
    fn get_variable_len_value_with_repetition<V: SplDiscriminate + VariableLenPack>(
        &self,
        repetition_number: usize,
    ) -> Result<V, ProgramError> {
        let data = get_bytes::<V>(self.get_data(), repetition_number)?;
        V::unpack_from_slice(data)
    }

    /// Unpacks a portion of the TLV data as the desired variable-length type
    /// for the first entry found
    fn get_first_variable_len_value<V: SplDiscriminate + VariableLenPack>(
        &self,
    ) -> Result<V, ProgramError> {
        self.get_variable_len_value_with_repetition::<V>(0)
    }

    /// Unpack a portion of the TLV data as bytes for the entry number specified
    fn get_bytes_with_repetition<V: SplDiscriminate>(
        &self,
        repetition_number: usize,
    ) -> Result<&[u8], ProgramError> {
        get_bytes::<V>(self.get_data(), repetition_number)
    }

    /// Unpack a portion of the TLV data as bytes for the first entry found
    fn get_first_bytes<V: SplDiscriminate>(&self) -> Result<&[u8], ProgramError> {
        self.get_bytes_with_repetition::<V>(0)
    }

    /// Iterates through the TLV entries, returning only the types
    fn get_discriminators(&self) -> Result<Vec<ArrayDiscriminator>, ProgramError> {
        get_discriminators_and_end_index(self.get_data()).map(|v| v.0)
    }

    /// Get the base size required for TLV data
    fn get_base_len() -> usize {
        get_base_len()
    }
}

/// Encapsulates owned TLV data
#[derive(Debug, PartialEq)]
pub struct TlvStateOwned {
    /// Raw TLV data, deserialized on demand
    data: Vec<u8>,
}
impl TlvStateOwned {
    /// Unpacks TLV state data
    ///
    /// Fails if no state is initialized or if data is too small
    pub fn unpack(data: Vec<u8>) -> Result<Self, ProgramError> {
        check_data(&data)?;
        Ok(Self { data })
    }
}
impl TlvState for TlvStateOwned {
    fn get_data(&self) -> &[u8] {
        &self.data
    }
}

/// Encapsulates immutable base state data (mint or account) with possible
/// extensions
#[derive(Debug, PartialEq)]
pub struct TlvStateBorrowed<'data> {
    /// Slice of data containing all TLV data, deserialized on demand
    data: &'data [u8],
}
impl<'data> TlvStateBorrowed<'data> {
    /// Unpacks TLV state data
    ///
    /// Fails if no state is initialized or if data is too small
    pub fn unpack(data: &'data [u8]) -> Result<Self, ProgramError> {
        check_data(data)?;
        Ok(Self { data })
    }
}
impl<'a> TlvState for TlvStateBorrowed<'a> {
    fn get_data(&self) -> &[u8] {
        self.data
    }
}

/// Encapsulates mutable base state data (mint or account) with possible
/// extensions
#[derive(Debug, PartialEq)]
pub struct TlvStateMut<'data> {
    /// Slice of data containing all TLV data, deserialized on demand
    data: &'data mut [u8],
}
impl<'data> TlvStateMut<'data> {
    /// Unpacks TLV state data
    ///
    /// Fails if no state is initialized or if data is too small
    pub fn unpack(data: &'data mut [u8]) -> Result<Self, ProgramError> {
        check_data(data)?;
        Ok(Self { data })
    }

    /// Unpack a portion of the TLV data as the desired type that allows
    /// modifying the type for the entry number specified
    pub fn get_value_with_repetition_mut<V: SplDiscriminate + Pod>(
        &mut self,
        repetition_number: usize,
    ) -> Result<&mut V, ProgramError> {
        let data = self.get_bytes_with_repetition_mut::<V>(repetition_number)?;
        pod_from_bytes_mut::<V>(data)
    }

    /// Unpack a portion of the TLV data as the desired type that allows
    /// modifying the type for the first entry found
    pub fn get_first_value_mut<V: SplDiscriminate + Pod>(
        &mut self,
    ) -> Result<&mut V, ProgramError> {
        self.get_value_with_repetition_mut::<V>(0)
    }

    /// Unpack a portion of the TLV data as mutable bytes for the entry number
    /// specified
    pub fn get_bytes_with_repetition_mut<V: SplDiscriminate>(
        &mut self,
        repetition_number: usize,
    ) -> Result<&mut [u8], ProgramError> {
        let TlvIndices {
            type_start: _,
            length_start,
            value_start,
            value_repetition_number: _,
        } = get_indices(
            self.data,
            V::SPL_DISCRIMINATOR,
            false,
            Some(repetition_number),
        )?;

        let length = pod_from_bytes::<Length>(&self.data[length_start..value_start])?;
        let value_end = value_start.saturating_add(usize::try_from(*length)?);
        if self.data.len() < value_end {
            return Err(ProgramError::InvalidAccountData);
        }
        Ok(&mut self.data[value_start..value_end])
    }

    /// Unpack a portion of the TLV data as mutable bytes for the first entry
    /// found
    pub fn get_first_bytes_mut<V: SplDiscriminate>(&mut self) -> Result<&mut [u8], ProgramError> {
        self.get_bytes_with_repetition_mut::<V>(0)
    }

    /// Packs the default TLV data into the first open slot in the data buffer.
    /// Handles repetition based on the boolean arg provided:
    /// * `true`:   If extension is already found in the buffer,
    /// it returns an error.
    /// * `false`:  Will add a new entry to the next open slot.
    pub fn init_value<V: SplDiscriminate + Pod + Default>(
        &mut self,
        allow_repetition: bool,
    ) -> Result<(&mut V, usize), ProgramError> {
        let length = size_of::<V>();
        let (buffer, repetition_number) = self.alloc::<V>(length, allow_repetition)?;
        let extension_ref = pod_from_bytes_mut::<V>(buffer)?;
        *extension_ref = V::default();
        Ok((extension_ref, repetition_number))
    }

    /// Packs a variable-length value into its appropriate data segment, where
    /// repeating discriminators _are_ allowed
    pub fn pack_variable_len_value_with_repetition<V: SplDiscriminate + VariableLenPack>(
        &mut self,
        value: &V,
        repetition_number: usize,
    ) -> Result<(), ProgramError> {
        let data = self.get_bytes_with_repetition_mut::<V>(repetition_number)?;
        // NOTE: Do *not* use `pack`, since the length check will cause
        // reallocations to smaller sizes to fail
        value.pack_into_slice(data)
    }

    /// Packs a variable-length value into its appropriate data segment, where
    /// no repeating discriminators are allowed
    pub fn pack_first_variable_len_value<V: SplDiscriminate + VariableLenPack>(
        &mut self,
        value: &V,
    ) -> Result<(), ProgramError> {
        self.pack_variable_len_value_with_repetition::<V>(value, 0)
    }

    /// Allocate the given number of bytes for the given SplDiscriminate
    pub fn alloc<V: SplDiscriminate>(
        &mut self,
        length: usize,
        allow_repetition: bool,
    ) -> Result<(&mut [u8], usize), ProgramError> {
        let TlvIndices {
            type_start,
            length_start,
            value_start,
            value_repetition_number,
        } = get_indices(
            self.data,
            V::SPL_DISCRIMINATOR,
            true,
            if allow_repetition { None } else { Some(0) },
        )?;

        let discriminator = ArrayDiscriminator::try_from(&self.data[type_start..length_start])?;
        if discriminator == ArrayDiscriminator::UNINITIALIZED {
            // write type
            let discriminator_ref = &mut self.data[type_start..length_start];
            discriminator_ref.copy_from_slice(V::SPL_DISCRIMINATOR.as_ref());
            // write length
            let length_ref =
                pod_from_bytes_mut::<Length>(&mut self.data[length_start..value_start])?;
            *length_ref = Length::try_from(length)?;

            let value_end = value_start.saturating_add(length);
            if self.data.len() < value_end {
                return Err(ProgramError::InvalidAccountData);
            }
            Ok((
                &mut self.data[value_start..value_end],
                value_repetition_number,
            ))
        } else {
            Err(TlvError::TypeAlreadyExists.into())
        }
    }

    /// Allocates and serializes a new TLV entry from a `VariableLenPack` type
    pub fn alloc_and_pack_variable_len_entry<V: SplDiscriminate + VariableLenPack>(
        &mut self,
        value: &V,
        allow_repetition: bool,
    ) -> Result<usize, ProgramError> {
        let length = value.get_packed_len()?;
        let (data, repetition_number) = self.alloc::<V>(length, allow_repetition)?;
        value.pack_into_slice(data)?;
        Ok(repetition_number)
    }

    /// Reallocate the given number of bytes for the given SplDiscriminate. If
    /// the new length is smaller, it will compact the rest of the buffer
    /// and zero out the difference at the end. If it's larger, it will move
    /// the rest of the buffer data and zero out the new data.
    pub fn realloc_with_repetition<V: SplDiscriminate>(
        &mut self,
        length: usize,
        repetition_number: usize,
    ) -> Result<&mut [u8], ProgramError> {
        let TlvIndices {
            type_start: _,
            length_start,
            value_start,
            value_repetition_number: _,
        } = get_indices(
            self.data,
            V::SPL_DISCRIMINATOR,
            false,
            Some(repetition_number),
        )?;
        let (_, end_index) = get_discriminators_and_end_index(self.data)?;
        let data_len = self.data.len();

        let length_ref = pod_from_bytes_mut::<Length>(&mut self.data[length_start..value_start])?;
        let old_length = usize::try_from(*length_ref)?;

        // check that we're not going to panic during `copy_within`
        if old_length < length {
            let new_end_index = end_index.saturating_add(length.saturating_sub(old_length));
            if new_end_index > data_len {
                return Err(ProgramError::InvalidAccountData);
            }
        }

        // write new length after the check, to avoid getting into a bad situation
        // if trying to recover from an error
        *length_ref = Length::try_from(length)?;

        let old_value_end = value_start.saturating_add(old_length);
        let new_value_end = value_start.saturating_add(length);
        self.data
            .copy_within(old_value_end..end_index, new_value_end);
        match old_length.cmp(&length) {
            Ordering::Greater => {
                // realloc to smaller, fill the end
                let new_end_index = end_index.saturating_sub(old_length.saturating_sub(length));
                self.data[new_end_index..end_index].fill(0);
            }
            Ordering::Less => {
                // realloc to bigger, fill the moved part
                self.data[old_value_end..new_value_end].fill(0);
            }
            Ordering::Equal => {} // nothing needed!
        }

        Ok(&mut self.data[value_start..new_value_end])
    }

    /// Reallocate the given number of bytes for the given SplDiscriminate,
    /// where no repeating discriminators are allowed
    pub fn realloc_first<V: SplDiscriminate>(
        &mut self,
        length: usize,
    ) -> Result<&mut [u8], ProgramError> {
        self.realloc_with_repetition::<V>(length, 0)
    }
}

impl<'a> TlvState for TlvStateMut<'a> {
    fn get_data(&self) -> &[u8] {
        self.data
    }
}

/// Packs a variable-length value into an existing TLV space, reallocating
/// the account and TLV as needed to accommodate for any change in space
pub fn realloc_and_pack_variable_len_with_repetition<V: SplDiscriminate + VariableLenPack>(
    account_info: &AccountInfo,
    value: &V,
    repetition_number: usize,
) -> Result<(), ProgramError> {
    let previous_length = {
        let data = account_info.try_borrow_data()?;
        let TlvIndices {
            type_start: _,
            length_start,
            value_start,
            value_repetition_number: _,
        } = get_indices(&data, V::SPL_DISCRIMINATOR, false, Some(repetition_number))?;
        usize::try_from(*pod_from_bytes::<Length>(&data[length_start..value_start])?)?
    };
    let new_length = value.get_packed_len()?;
    let previous_account_size = account_info.try_data_len()?;
    if previous_length < new_length {
        // size increased, so realloc the account, then the TLV entry, then write data
        let additional_bytes = new_length
            .checked_sub(previous_length)
            .ok_or(ProgramError::AccountDataTooSmall)?;
        account_info.realloc(previous_account_size.saturating_add(additional_bytes), true)?;
        let mut buffer = account_info.try_borrow_mut_data()?;
        let mut state = TlvStateMut::unpack(&mut buffer)?;
        state.realloc_with_repetition::<V>(new_length, repetition_number)?;
        state.pack_variable_len_value_with_repetition(value, repetition_number)?;
    } else {
        // do it backwards otherwise, write the state, realloc TLV, then the account
        let mut buffer = account_info.try_borrow_mut_data()?;
        let mut state = TlvStateMut::unpack(&mut buffer)?;
        state.pack_variable_len_value_with_repetition(value, repetition_number)?;
        let removed_bytes = previous_length
            .checked_sub(new_length)
            .ok_or(ProgramError::AccountDataTooSmall)?;
        if removed_bytes > 0 {
            // we decreased the size, so need to realloc the TLV, then the account
            state.realloc_with_repetition::<V>(new_length, repetition_number)?;
            // this is probably fine, but be safe and avoid invalidating references
            drop(buffer);
            account_info.realloc(previous_account_size.saturating_sub(removed_bytes), false)?;
        }
    }
    Ok(())
}

/// Packs a variable-length value into an existing TLV space, where no repeating
/// discriminators are allowed
pub fn realloc_and_pack_first_variable_len<V: SplDiscriminate + VariableLenPack>(
    account_info: &AccountInfo,
    value: &V,
) -> Result<(), ProgramError> {
    realloc_and_pack_variable_len_with_repetition::<V>(account_info, value, 0)
}

/// Get the base size required for TLV data
const fn get_base_len() -> usize {
    get_indices_unchecked(0, 0).value_start
}

fn check_data(tlv_data: &[u8]) -> Result<(), ProgramError> {
    // should be able to iterate through all entries in the TLV structure
    let _ = get_discriminators_and_end_index(tlv_data)?;
    Ok(())
}

#[cfg(test)]
mod test {
    use {
        super::*,
        bytemuck::{Pod, Zeroable},
    };

    const TEST_BUFFER: &[u8] = &[
        1, 1, 1, 1, 1, 1, 1, 1, // discriminator
        32, 0, 0, 0, // length
        1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1,
        1, 1, // value
        0, 0, // empty, not enough for a discriminator
    ];

    const TEST_BIG_BUFFER: &[u8] = &[
        1, 1, 1, 1, 1, 1, 1, 1, // discriminator
        32, 0, 0, 0, // length
        1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1,
        1, 1, // value
        0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0,
        0, // empty, but enough for a discriminator and empty value
    ];

    #[repr(C)]
    #[derive(Clone, Copy, Debug, Default, PartialEq, Pod, Zeroable)]
    struct TestValue {
        data: [u8; 32],
    }
    impl SplDiscriminate for TestValue {
        const SPL_DISCRIMINATOR: ArrayDiscriminator =
            ArrayDiscriminator::new([1; ArrayDiscriminator::LENGTH]);
    }

    #[repr(C)]
    #[derive(Clone, Copy, Debug, Default, PartialEq, Pod, Zeroable)]
    struct TestSmallValue {
        data: [u8; 3],
    }
    impl SplDiscriminate for TestSmallValue {
        const SPL_DISCRIMINATOR: ArrayDiscriminator =
            ArrayDiscriminator::new([2; ArrayDiscriminator::LENGTH]);
    }

    #[repr(transparent)]
    #[derive(Clone, Copy, Debug, Default, PartialEq, Pod, Zeroable)]
    struct TestEmptyValue;
    impl SplDiscriminate for TestEmptyValue {
        const SPL_DISCRIMINATOR: ArrayDiscriminator =
            ArrayDiscriminator::new([3; ArrayDiscriminator::LENGTH]);
    }

    #[repr(C)]
    #[derive(Clone, Copy, Debug, PartialEq, Pod, Zeroable)]
    struct TestNonZeroDefault {
        data: [u8; 5],
    }
    const TEST_NON_ZERO_DEFAULT_DATA: [u8; 5] = [4; 5];
    impl SplDiscriminate for TestNonZeroDefault {
        const SPL_DISCRIMINATOR: ArrayDiscriminator =
            ArrayDiscriminator::new([4; ArrayDiscriminator::LENGTH]);
    }
    impl Default for TestNonZeroDefault {
        fn default() -> Self {
            Self {
                data: TEST_NON_ZERO_DEFAULT_DATA,
            }
        }
    }

    #[test]
    fn unpack_opaque_buffer() {
        let state = TlvStateBorrowed::unpack(TEST_BUFFER).unwrap();
        let value = state.get_first_value::<TestValue>().unwrap();
        assert_eq!(value.data, [1; 32]);
        assert_eq!(
            state.get_first_value::<TestEmptyValue>(),
            Err(ProgramError::InvalidAccountData)
        );

        let mut test_buffer = TEST_BUFFER.to_vec();
        let state = TlvStateMut::unpack(&mut test_buffer).unwrap();
        let value = state.get_first_value::<TestValue>().unwrap();
        assert_eq!(value.data, [1; 32]);
        let state = TlvStateOwned::unpack(test_buffer).unwrap();
        let value = state.get_first_value::<TestValue>().unwrap();
        assert_eq!(value.data, [1; 32]);
    }

    #[test]
    fn fail_unpack_opaque_buffer() {
        // input buffer too small
        let mut buffer = vec![0, 3];
        assert_eq!(
            TlvStateBorrowed::unpack(&buffer),
            Err(ProgramError::InvalidAccountData)
        );
        assert_eq!(
            TlvStateMut::unpack(&mut buffer),
            Err(ProgramError::InvalidAccountData)
        );
        assert_eq!(
            TlvStateMut::unpack(&mut buffer),
            Err(ProgramError::InvalidAccountData)
        );

        // tweak the discriminator
        let mut buffer = TEST_BUFFER.to_vec();
        buffer[0] += 1;
        let state = TlvStateMut::unpack(&mut buffer).unwrap();
        assert_eq!(
            state.get_first_value::<TestValue>(),
            Err(ProgramError::InvalidAccountData)
        );

        // tweak the length, too big
        let mut buffer = TEST_BUFFER.to_vec();
        buffer[ArrayDiscriminator::LENGTH] += 10;
        assert_eq!(
            TlvStateMut::unpack(&mut buffer),
            Err(ProgramError::InvalidAccountData)
        );

        // tweak the length, too small
        let mut buffer = TEST_BIG_BUFFER.to_vec();
        buffer[ArrayDiscriminator::LENGTH] -= 1;
        let state = TlvStateMut::unpack(&mut buffer).unwrap();
        assert_eq!(
            state.get_first_value::<TestValue>(),
            Err(ProgramError::InvalidArgument)
        );

        // data buffer is too small for type
        let buffer = &TEST_BUFFER[..TEST_BUFFER.len() - 5];
        assert_eq!(
            TlvStateBorrowed::unpack(buffer),
            Err(ProgramError::InvalidAccountData)
        );
    }

    #[test]
    fn get_discriminators_with_opaque_buffer() {
        // incorrect due to the length
        assert_eq!(
            get_discriminators_and_end_index(&[1, 0, 1, 1]).unwrap_err(),
            ProgramError::InvalidAccountData,
        );
        // correct due to the good discriminator length and zero length
        assert_eq!(
            get_discriminators_and_end_index(&[1, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0]).unwrap(),
            (vec![ArrayDiscriminator::from(1)], 12)
        );
        // correct since it's just uninitialized data
        assert_eq!(
            get_discriminators_and_end_index(&[0, 0, 0, 0, 0, 0, 0, 0]).unwrap(),
            (vec![], 0)
        );
    }

    #[test]
    fn value_pack_unpack() {
        let account_size =
            get_base_len() + size_of::<TestValue>() + get_base_len() + size_of::<TestSmallValue>();
        let mut buffer = vec![0; account_size];

        let mut state = TlvStateMut::unpack(&mut buffer).unwrap();

        // success init and write value
        let value = state.init_value::<TestValue>(false).unwrap().0;
        let data = [100; 32];
        value.data = data;
        assert_eq!(
            &state.get_discriminators().unwrap(),
            &[TestValue::SPL_DISCRIMINATOR],
        );
        assert_eq!(&state.get_first_value::<TestValue>().unwrap().data, &data,);

        // fail init extension when already initialized
        assert_eq!(
            state.init_value::<TestValue>(false).unwrap_err(),
            TlvError::TypeAlreadyExists.into(),
        );

        // check raw buffer
        let mut expect = vec![];
        expect.extend_from_slice(TestValue::SPL_DISCRIMINATOR.as_ref());
        expect.extend_from_slice(&u32::try_from(size_of::<TestValue>()).unwrap().to_le_bytes());
        expect.extend_from_slice(&data);
        expect.extend_from_slice(&[0; size_of::<ArrayDiscriminator>()]);
        expect.extend_from_slice(&[0; size_of::<Length>()]);
        expect.extend_from_slice(&[0; size_of::<TestSmallValue>()]);
        assert_eq!(expect, buffer);

        // check unpacking
        let mut state = TlvStateMut::unpack(&mut buffer).unwrap();
        let unpacked = state.get_first_value_mut::<TestValue>().unwrap();
        assert_eq!(*unpacked, TestValue { data });

        // update extension
        let new_data = [101; 32];
        unpacked.data = new_data;

        // check updates are propagated
        let state = TlvStateBorrowed::unpack(&buffer).unwrap();
        let unpacked = state.get_first_value::<TestValue>().unwrap();
        assert_eq!(*unpacked, TestValue { data: new_data });

        // check raw buffer
        let mut expect = vec![];
        expect.extend_from_slice(TestValue::SPL_DISCRIMINATOR.as_ref());
        expect.extend_from_slice(&u32::try_from(size_of::<TestValue>()).unwrap().to_le_bytes());
        expect.extend_from_slice(&new_data);
        expect.extend_from_slice(&[0; size_of::<ArrayDiscriminator>()]);
        expect.extend_from_slice(&[0; size_of::<Length>()]);
        expect.extend_from_slice(&[0; size_of::<TestSmallValue>()]);
        assert_eq!(expect, buffer);

        let mut state = TlvStateMut::unpack(&mut buffer).unwrap();
        // init one more value
        let new_value = state.init_value::<TestSmallValue>(false).unwrap().0;
        let small_data = [102; 3];
        new_value.data = small_data;

        assert_eq!(
            &state.get_discriminators().unwrap(),
            &[
                TestValue::SPL_DISCRIMINATOR,
                TestSmallValue::SPL_DISCRIMINATOR
            ]
        );

        // check raw buffer
        let mut expect = vec![];
        expect.extend_from_slice(TestValue::SPL_DISCRIMINATOR.as_ref());
        expect.extend_from_slice(&u32::try_from(size_of::<TestValue>()).unwrap().to_le_bytes());
        expect.extend_from_slice(&new_data);
        expect.extend_from_slice(TestSmallValue::SPL_DISCRIMINATOR.as_ref());
        expect.extend_from_slice(
            &u32::try_from(size_of::<TestSmallValue>())
                .unwrap()
                .to_le_bytes(),
        );
        expect.extend_from_slice(&small_data);
        assert_eq!(expect, buffer);

        // fail to init one more extension that does not fit
        let mut state = TlvStateMut::unpack(&mut buffer).unwrap();
        assert_eq!(
            state.init_value::<TestEmptyValue>(false),
            Err(ProgramError::InvalidAccountData),
        );
    }

    #[test]
    fn value_any_order() {
        let account_size =
            get_base_len() + size_of::<TestValue>() + get_base_len() + size_of::<TestSmallValue>();
        let mut buffer = vec![0; account_size];

        let mut state = TlvStateMut::unpack(&mut buffer).unwrap();

        let data = [99; 32];
        let small_data = [98; 3];

        // write values
        let value = state.init_value::<TestValue>(false).unwrap().0;
        value.data = data;
        let value = state.init_value::<TestSmallValue>(false).unwrap().0;
        value.data = small_data;

        assert_eq!(
            &state.get_discriminators().unwrap(),
            &[
                TestValue::SPL_DISCRIMINATOR,
                TestSmallValue::SPL_DISCRIMINATOR,
            ]
        );

        // write values in a different order
        let mut other_buffer = vec![0; account_size];
        let mut state = TlvStateMut::unpack(&mut other_buffer).unwrap();

        let value = state.init_value::<TestSmallValue>(false).unwrap().0;
        value.data = small_data;
        let value = state.init_value::<TestValue>(false).unwrap().0;
        value.data = data;

        assert_eq!(
            &state.get_discriminators().unwrap(),
            &[
                TestSmallValue::SPL_DISCRIMINATOR,
                TestValue::SPL_DISCRIMINATOR,
            ]
        );

        // buffers are NOT the same because written in a different order
        assert_ne!(buffer, other_buffer);
        let state = TlvStateBorrowed::unpack(&buffer).unwrap();
        let other_state = TlvStateBorrowed::unpack(&other_buffer).unwrap();

        // BUT values are the same
        assert_eq!(
            state.get_first_value::<TestValue>().unwrap(),
            other_state.get_first_value::<TestValue>().unwrap()
        );
        assert_eq!(
            state.get_first_value::<TestSmallValue>().unwrap(),
            other_state.get_first_value::<TestSmallValue>().unwrap()
        );
    }

    #[test]
    fn init_nonzero_default() {
        let account_size = get_base_len() + size_of::<TestNonZeroDefault>();
        let mut buffer = vec![0; account_size];
        let mut state = TlvStateMut::unpack(&mut buffer).unwrap();
        let value = state.init_value::<TestNonZeroDefault>(false).unwrap().0;
        assert_eq!(value.data, TEST_NON_ZERO_DEFAULT_DATA);
    }

    #[test]
    fn init_buffer_too_small() {
        let account_size = get_base_len() + size_of::<TestValue>();
        let mut buffer = vec![0; account_size - 1];
        let mut state = TlvStateMut::unpack(&mut buffer).unwrap();
        let err = state.init_value::<TestValue>(false).unwrap_err();
        assert_eq!(err, ProgramError::InvalidAccountData);

        // hack the buffer to look like it was initialized, still fails
        let discriminator_ref = &mut state.data[0..ArrayDiscriminator::LENGTH];
        discriminator_ref.copy_from_slice(TestValue::SPL_DISCRIMINATOR.as_ref());
        state.data[ArrayDiscriminator::LENGTH] = 32;
        let err = state.get_first_value::<TestValue>().unwrap_err();
        assert_eq!(err, ProgramError::InvalidAccountData);
        assert_eq!(
            state.get_discriminators().unwrap_err(),
            ProgramError::InvalidAccountData
        );
    }

    #[test]
    fn value_with_no_data() {
        let account_size = get_base_len() + size_of::<TestEmptyValue>();
        let mut buffer = vec![0; account_size];
        let mut state = TlvStateMut::unpack(&mut buffer).unwrap();

        assert_eq!(
            state.get_first_value::<TestEmptyValue>().unwrap_err(),
            TlvError::TypeNotFound.into(),
        );

        state.init_value::<TestEmptyValue>(false).unwrap();
        state.get_first_value::<TestEmptyValue>().unwrap();

        // re-init fails
        assert_eq!(
            state.init_value::<TestEmptyValue>(false).unwrap_err(),
            TlvError::TypeAlreadyExists.into(),
        );
    }

    #[test]
    fn alloc_first() {
        let tlv_size = 1;
        let account_size = get_base_len() + tlv_size;
        let mut buffer = vec![0; account_size];
        let mut state = TlvStateMut::unpack(&mut buffer).unwrap();

        // not enough room
        let data = state.alloc::<TestValue>(tlv_size, false).unwrap().0;
        assert_eq!(
            pod_from_bytes_mut::<TestValue>(data).unwrap_err(),
            ProgramError::InvalidArgument,
        );

        // can't double alloc
        assert_eq!(
            state.alloc::<TestValue>(tlv_size, false).unwrap_err(),
            TlvError::TypeAlreadyExists.into(),
        );
    }

    #[test]
    fn alloc_with_repetition() {
        let tlv_size = 1;
        let account_size = (get_base_len() + tlv_size) * 2;
        let mut buffer = vec![0; account_size];
        let mut state = TlvStateMut::unpack(&mut buffer).unwrap();

        let (data, repetition_number) = state.alloc::<TestValue>(tlv_size, true).unwrap();
        assert_eq!(repetition_number, 0);

        // not enough room
        assert_eq!(
            pod_from_bytes_mut::<TestValue>(data).unwrap_err(),
            ProgramError::InvalidArgument,
        );

        // Can alloc again!
        let (_data, repetition_number) = state.alloc::<TestValue>(tlv_size, true).unwrap();
        assert_eq!(repetition_number, 1);
    }

    #[test]
    fn realloc_first() {
        const TLV_SIZE: usize = 10;
        const EXTRA_SPACE: usize = 5;
        const SMALL_SIZE: usize = 2;
        const ACCOUNT_SIZE: usize = get_base_len()
            + TLV_SIZE
            + EXTRA_SPACE
            + get_base_len()
            + size_of::<TestNonZeroDefault>();
        let mut buffer = vec![0; ACCOUNT_SIZE];
        let mut state = TlvStateMut::unpack(&mut buffer).unwrap();

        // alloc both types
        let _ = state.alloc::<TestValue>(TLV_SIZE, false).unwrap();
        let _ = state.init_value::<TestNonZeroDefault>(false).unwrap();

        // realloc first entry to larger, all 0
        let data = state
            .realloc_first::<TestValue>(TLV_SIZE + EXTRA_SPACE)
            .unwrap();
        assert_eq!(data, [0; TLV_SIZE + EXTRA_SPACE]);
        let value = state.get_first_value::<TestNonZeroDefault>().unwrap();
        assert_eq!(*value, TestNonZeroDefault::default());

        // realloc to smaller, still all 0
        let data = state.realloc_first::<TestValue>(SMALL_SIZE).unwrap();
        assert_eq!(data, [0; SMALL_SIZE]);
        let value = state.get_first_value::<TestNonZeroDefault>().unwrap();
        assert_eq!(*value, TestNonZeroDefault::default());
        let (_, end_index) = get_discriminators_and_end_index(&buffer).unwrap();
        assert_eq!(
            &buffer[end_index..ACCOUNT_SIZE],
            [0; TLV_SIZE + EXTRA_SPACE - SMALL_SIZE]
        );

        // unpack again since we dropped the last `state`
        let mut state = TlvStateMut::unpack(&mut buffer).unwrap();
        // realloc too much, fails
        assert_eq!(
            state
                .realloc_first::<TestValue>(TLV_SIZE + EXTRA_SPACE + 1)
                .unwrap_err(),
            ProgramError::InvalidAccountData,
        );
    }

    #[test]
    fn realloc_with_repeating_entries() {
        const TLV_SIZE: usize = 10;
        const EXTRA_SPACE: usize = 5;
        const SMALL_SIZE: usize = 2;
        const ACCOUNT_SIZE: usize = get_base_len()
            + TLV_SIZE
            + EXTRA_SPACE
            + get_base_len()
            + TLV_SIZE
            + get_base_len()
            + size_of::<TestNonZeroDefault>();
        let mut buffer = vec![0; ACCOUNT_SIZE];
        let mut state = TlvStateMut::unpack(&mut buffer).unwrap();

        // alloc both types, two for the first type and one for the second
        let _ = state.alloc::<TestValue>(TLV_SIZE, true).unwrap();
        let _ = state.alloc::<TestValue>(TLV_SIZE, true).unwrap();
        let _ = state.init_value::<TestNonZeroDefault>(true).unwrap();

        // realloc first entry to larger, all 0
        let data = state
            .realloc_with_repetition::<TestValue>(TLV_SIZE + EXTRA_SPACE, 0)
            .unwrap();
        assert_eq!(data, [0; TLV_SIZE + EXTRA_SPACE]);
        let value = state.get_bytes_with_repetition::<TestValue>(0).unwrap();
        assert_eq!(*value, [0; TLV_SIZE + EXTRA_SPACE]);
        let value = state.get_bytes_with_repetition::<TestValue>(1).unwrap();
        assert_eq!(*value, [0; TLV_SIZE]);
        let value = state.get_first_value::<TestNonZeroDefault>().unwrap();
        assert_eq!(*value, TestNonZeroDefault::default());

        // realloc to smaller, still all 0
        let data = state
            .realloc_with_repetition::<TestValue>(SMALL_SIZE, 0)
            .unwrap();
        assert_eq!(data, [0; SMALL_SIZE]);
        let value = state.get_bytes_with_repetition::<TestValue>(0).unwrap();
        assert_eq!(*value, [0; SMALL_SIZE]);
        let value = state.get_bytes_with_repetition::<TestValue>(1).unwrap();
        assert_eq!(*value, [0; TLV_SIZE]);
        let value = state.get_first_value::<TestNonZeroDefault>().unwrap();
        assert_eq!(*value, TestNonZeroDefault::default());
        let (_, end_index) = get_discriminators_and_end_index(&buffer).unwrap();
        assert_eq!(
            &buffer[end_index..ACCOUNT_SIZE],
            [0; TLV_SIZE + EXTRA_SPACE - SMALL_SIZE]
        );

        // unpack again since we dropped the last `state`
        let mut state = TlvStateMut::unpack(&mut buffer).unwrap();
        // realloc too much, fails
        assert_eq!(
            state
                .realloc_with_repetition::<TestValue>(TLV_SIZE + EXTRA_SPACE + 1, 0)
                .unwrap_err(),
            ProgramError::InvalidAccountData,
        );
    }

    #[derive(Clone, Debug, PartialEq)]
    struct TestVariableLen {
        data: String, // test with a variable length type
    }
    impl SplDiscriminate for TestVariableLen {
        const SPL_DISCRIMINATOR: ArrayDiscriminator =
            ArrayDiscriminator::new([5; ArrayDiscriminator::LENGTH]);
    }
    impl VariableLenPack for TestVariableLen {
        fn pack_into_slice(&self, dst: &mut [u8]) -> Result<(), ProgramError> {
            let bytes = self.data.as_bytes();
            let end = 8 + bytes.len();
            if dst.len() < end {
                Err(ProgramError::InvalidAccountData)
            } else {
                dst[..8].copy_from_slice(&self.data.len().to_le_bytes());
                dst[8..end].copy_from_slice(bytes);
                Ok(())
            }
        }
        fn unpack_from_slice(src: &[u8]) -> Result<Self, ProgramError> {
            let length = u64::from_le_bytes(src[..8].try_into().unwrap()) as usize;
            if src[8..8 + length].len() != length {
                return Err(ProgramError::InvalidAccountData);
            }
            let data = std::str::from_utf8(&src[8..8 + length])
                .unwrap()
                .to_string();
            Ok(Self { data })
        }
        fn get_packed_len(&self) -> Result<usize, ProgramError> {
            Ok(size_of::<u64>().saturating_add(self.data.len()))
        }
    }

    #[test]
    fn first_variable_len_value() {
        let initial_data = "This is a pretty cool test!";
        // exactly the right size
        let tlv_size = 8 + initial_data.len();
        let account_size = get_base_len() + tlv_size;
        let mut buffer = vec![0; account_size];
        let mut state = TlvStateMut::unpack(&mut buffer).unwrap();

        // don't actually need to hold onto the data!
        let _ = state.alloc::<TestVariableLen>(tlv_size, false).unwrap();
        let test_variable_len = TestVariableLen {
            data: initial_data.to_string(),
        };
        state
            .pack_first_variable_len_value(&test_variable_len)
            .unwrap();
        let deser = state
            .get_first_variable_len_value::<TestVariableLen>()
            .unwrap();
        assert_eq!(deser, test_variable_len);

        // writing too much data fails
        let too_much_data = "This is a pretty cool test!?";
        assert_eq!(
            state
                .pack_first_variable_len_value(&TestVariableLen {
                    data: too_much_data.to_string(),
                })
                .unwrap_err(),
            ProgramError::InvalidAccountData
        );
    }

    #[test]
    fn variable_len_value_with_repetition() {
        let variable_len_1 = TestVariableLen {
            data: "Let's see if we can pack multiple variable length values".to_string(),
        };
        let tlv_size_1 = 8 + variable_len_1.data.len();

        let variable_len_2 = TestVariableLen {
            data: "I think we can".to_string(),
        };
        let tlv_size_2 = 8 + variable_len_2.data.len();

        let variable_len_3 = TestVariableLen {
            data: "In fact, I know we can!".to_string(),
        };
        let tlv_size_3 = 8 + variable_len_3.data.len();

        let variable_len_4 = TestVariableLen {
            data: "How cool is this?".to_string(),
        };
        let tlv_size_4 = 8 + variable_len_4.data.len();

        let account_size = get_base_len()
            + tlv_size_1
            + get_base_len()
            + tlv_size_2
            + get_base_len()
            + tlv_size_3
            + get_base_len()
            + tlv_size_4;
        let mut buffer = vec![0; account_size];
        let mut state = TlvStateMut::unpack(&mut buffer).unwrap();

        let (_, repetition_number) = state.alloc::<TestVariableLen>(tlv_size_1, true).unwrap();
        state
            .pack_variable_len_value_with_repetition(&variable_len_1, repetition_number)
            .unwrap();
        assert_eq!(repetition_number, 0);
        assert_eq!(
            state
                .get_first_variable_len_value::<TestVariableLen>()
                .unwrap(),
            variable_len_1,
        );

        let (_, repetition_number) = state.alloc::<TestVariableLen>(tlv_size_2, true).unwrap();
        state
            .pack_variable_len_value_with_repetition(&variable_len_2, repetition_number)
            .unwrap();
        assert_eq!(repetition_number, 1);
        assert_eq!(
            state
                .get_variable_len_value_with_repetition::<TestVariableLen>(repetition_number)
                .unwrap(),
            variable_len_2,
        );

        let (_, repetition_number) = state.alloc::<TestVariableLen>(tlv_size_3, true).unwrap();
        state
            .pack_variable_len_value_with_repetition(&variable_len_3, repetition_number)
            .unwrap();
        assert_eq!(repetition_number, 2);
        assert_eq!(
            state
                .get_variable_len_value_with_repetition::<TestVariableLen>(repetition_number)
                .unwrap(),
            variable_len_3,
        );

        let (_, repetition_number) = state.alloc::<TestVariableLen>(tlv_size_4, true).unwrap();
        state
            .pack_variable_len_value_with_repetition(&variable_len_4, repetition_number)
            .unwrap();
        assert_eq!(repetition_number, 3);
        assert_eq!(
            state
                .get_variable_len_value_with_repetition::<TestVariableLen>(repetition_number)
                .unwrap(),
            variable_len_4,
        );
    }

    #[test]
    fn add_entry_mix_and_match() {
        let mut buffer = vec![];

        // Add an entry for a fixed length value
        let fixed_data = TestValue { data: [1; 32] };
        let tlv_size = get_base_len() + size_of::<TestValue>();
        buffer.extend(vec![0; tlv_size]);
        {
            let mut state = TlvStateMut::unpack(&mut buffer).unwrap();
            let (value, repetition_number) = state.init_value::<TestValue>(true).unwrap();
            value.data = fixed_data.data;
            assert_eq!(repetition_number, 0);
            assert_eq!(*value, fixed_data);
        }

        // Add an entry for a variable length value
        let variable_data = TestVariableLen {
            data: "This is my first variable length entry!".to_string(),
        };
        let tlv_size = get_base_len() + 8 + variable_data.data.len();
        buffer.extend(vec![0; tlv_size]);
        {
            let mut state = TlvStateMut::unpack(&mut buffer).unwrap();
            let repetition_number = state
                .alloc_and_pack_variable_len_entry(&variable_data, true)
                .unwrap();
            let value = state
                .get_variable_len_value_with_repetition::<TestVariableLen>(repetition_number)
                .unwrap();
            assert_eq!(repetition_number, 0);
            assert_eq!(value, variable_data);
        }

        // Add another entry for a variable length value
        let variable_data = TestVariableLen {
            data: "This is actually my second variable length entry!".to_string(),
        };
        let tlv_size = get_base_len() + 8 + variable_data.data.len();
        buffer.extend(vec![0; tlv_size]);
        {
            let mut state = TlvStateMut::unpack(&mut buffer).unwrap();
            let repetition_number = state
                .alloc_and_pack_variable_len_entry(&variable_data, true)
                .unwrap();
            let value = state
                .get_variable_len_value_with_repetition::<TestVariableLen>(repetition_number)
                .unwrap();
            assert_eq!(repetition_number, 1);
            assert_eq!(value, variable_data);
        }

        // Add another entry for a fixed length value
        let fixed_data = TestValue { data: [2; 32] };
        let tlv_size = get_base_len() + size_of::<TestValue>();
        buffer.extend(vec![0; tlv_size]);
        {
            let mut state = TlvStateMut::unpack(&mut buffer).unwrap();
            let (value, repetition_number) = state.init_value::<TestValue>(true).unwrap();
            value.data = fixed_data.data;
            assert_eq!(repetition_number, 1);
            assert_eq!(*value, fixed_data);
        }

        // Add another entry for a fixed length value
        let fixed_data = TestValue { data: [3; 32] };
        let tlv_size = get_base_len() + size_of::<TestValue>();
        buffer.extend(vec![0; tlv_size]);
        {
            let mut state = TlvStateMut::unpack(&mut buffer).unwrap();
            let (value, repetition_number) = state.init_value::<TestValue>(true).unwrap();
            value.data = fixed_data.data;
            assert_eq!(repetition_number, 2);
            assert_eq!(*value, fixed_data);
        }

        // Add another entry for a variable length value
        let variable_data = TestVariableLen {
            data: "Wow! My third variable length entry!".to_string(),
        };
        let tlv_size = get_base_len() + 8 + variable_data.data.len();
        buffer.extend(vec![0; tlv_size]);
        {
            let mut state = TlvStateMut::unpack(&mut buffer).unwrap();
            let repetition_number = state
                .alloc_and_pack_variable_len_entry(&variable_data, true)
                .unwrap();
            let value = state
                .get_variable_len_value_with_repetition::<TestVariableLen>(repetition_number)
                .unwrap();
            assert_eq!(repetition_number, 2);
            assert_eq!(value, variable_data);
        }
    }
}