cln-plugin 0.3.0

A CLN plugin library. Write your plugin in Rust.
Documentation
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
721
722
723
724
725
726
727
728
729
730
731
732
733
734
735
736
737
738
739
740
741
742
743
744
745
746
747
748
749
750
751
752
753
754
755
756
757
758
759
760
761
762
763
764
765
766
767
768
769
770
771
772
773
774
775
776
777
778
779
780
781
782
783
784
785
786
787
788
789
790
791
792
793
794
795
796
797
798
799
800
801
802
803
804
805
806
807
808
809
810
811
812
813
814
815
816
817
818
819
820
821
822
823
824
825
826
827
828
829
830
831
832
833
834
835
836
#include "config.h"
#include <ccan/array_size/array_size.h>
#include <ccan/cast/cast.h>
#include <ccan/crypto/siphash24/siphash24.h>
#include <ccan/htable/htable_type.h>
#include <ccan/json_escape/json_escape.h>
#include <ccan/json_out/json_out.h>
#include <ccan/mem/mem.h>
#include <ccan/rune/rune.h>
#include <ccan/tal/str/str.h>
#include <ccan/time/time.h>
#include <common/json_param.h>
#include <common/json_stream.h>
#include <common/memleak.h>
#include <common/pseudorand.h>
#include <plugins/libplugin.h>

/* We (as your local commando command) detected an error. */
#define COMMANDO_ERROR_LOCAL 0x4c4f
/* Remote (as executing your commando command) detected an error. */
#define COMMANDO_ERROR_REMOTE 0x4c50
/* Specifically: bad/missing rune */
#define COMMANDO_ERROR_REMOTE_AUTH 0x4c51

enum commando_msgtype {
	/* Requests are split across multiple CONTINUES, then TERM. */
	COMMANDO_MSG_CMD_CONTINUES = 0x4c4d,
	COMMANDO_MSG_CMD_TERM = 0x4c4f,
	/* Replies are split across multiple CONTINUES, then TERM. */
	COMMANDO_MSG_REPLY_CONTINUES = 0x594b,
	COMMANDO_MSG_REPLY_TERM = 0x594d,
};

struct commando {
	/* Only non-NULL for outgoing cmds */
	struct command *cmd;
	struct node_id peer;
	u64 id;

	/* This is set to NULL if they seem to be spamming us! */
	u8 *contents;

	/* Literal JSON token containing JSON id (including "") */
	const char *json_id;
};

static struct plugin *plugin;
static struct commando **outgoing_commands;
static struct commando **incoming_commands;

/* The minimum fields required to respond. */
static struct commando *new_commando(const tal_t *ctx,
				     struct command *cmd,
				     const struct node_id *peer,
				     u64 id)
{
	struct commando *commando = tal(ctx, struct commando);

	commando->cmd = cmd;
	commando->peer = *peer;
	commando->id = id;

	commando->contents = NULL;
	commando->json_id = NULL;

	return commando;
}

/* NULL peer: don't care about peer.  NULL id: don't care about id */
static struct commando *find_commando(struct commando **arr,
				      const struct node_id *peer,
				      const u64 *id)
{
	for (size_t i = 0; i < tal_count(arr); i++) {
		if (id && arr[i]->id != *id)
			continue;
		if (peer && !node_id_eq(&arr[i]->peer, peer))
			continue;
		return arr[i];
	}
	return NULL;
}

static void destroy_commando(struct commando *commando, struct commando ***arr)
{
	for (size_t i = 0; i < tal_count(*arr); i++) {
		if ((*arr)[i] == commando) {
			tal_arr_remove(arr, i);
			return;
		}
	}
	abort();
}

/* Append to commando->contents: set to NULL if we've over max. */
static void append_contents(struct commando *commando, const u8 *msg, size_t msglen,
			    size_t maxlen)
{
	size_t len = tal_count(commando->contents);

	if (!commando->contents)
		return;

	if (len + msglen > maxlen) {
		commando->contents = tal_free(commando->contents);
		return;
	}

	tal_resize(&commando->contents, len + msglen);
	memcpy(commando->contents + len, msg, msglen);
}

struct reply {
	struct commando *incoming;
	char *buf;
	size_t off, len;
};

/* Calls itself repeatedly: first time, result is NULL */
static struct command_result *send_response(struct command *cmd,
					    const char *method UNUSED,
					    const char *buf UNUSED,
					    const jsmntok_t *result,
					    struct reply *reply)
{
	size_t msglen = reply->len - reply->off;
	u8 *cmd_msg;
	enum commando_msgtype msgtype;
	struct out_req *req;

	/* Limit is 64k, but there's a little overhead */
	if (msglen > 65000) {
		msglen = 65000;
		msgtype = COMMANDO_MSG_REPLY_CONTINUES;
	} else {
		if (msglen == 0) {
			tal_free(reply);
			return command_hook_success(cmd);
		}
		msgtype = COMMANDO_MSG_REPLY_TERM;
	}

	cmd_msg = tal_arr(NULL, u8, 0);
	towire_u16(&cmd_msg, msgtype);
	towire_u64(&cmd_msg, reply->incoming->id);
	towire(&cmd_msg, reply->buf + reply->off, msglen);
	reply->off += msglen;

	req = jsonrpc_request_start(cmd, "sendcustommsg",
				    send_response, send_response,
				    reply);
	json_add_node_id(req->js, "node_id", &reply->incoming->peer);
	json_add_hex_talarr(req->js, "msg", cmd_msg);
	tal_free(cmd_msg);
	send_outreq(req);

	return command_still_pending(cmd);
}

static struct command_result *cmd_done(struct command *command,
				       const char *method,
				       const char *buf,
				       const jsmntok_t *obj,
				       struct commando *incoming)
{
	struct reply *reply = tal(plugin, struct reply);
	reply->incoming = tal_steal(reply, incoming);

	/* We make a copy, but substititing the original id! */
	if (incoming->json_id) {
		const char *id_start, *id_end;
		const jsmntok_t *id = json_get_member(buf, obj, "id");
		size_t off;

		/* Old id we're going to omit */
		id_start = json_tok_full(buf, id);
		id_end = id_start + json_tok_full_len(id);

		reply->len = obj->end - obj->start
			- (id_end - id_start)
			+ strlen(incoming->json_id);
		reply->buf = tal_arr(reply, char, reply->len);
		memcpy(reply->buf, buf + obj->start,
		       id_start - (buf + obj->start));
		off = id_start - (buf + obj->start);
		memcpy(reply->buf + off, incoming->json_id, strlen(incoming->json_id));
		off += strlen(incoming->json_id);
		memcpy(reply->buf + off, id_end, (buf + obj->end) - id_end);
	} else {
		reply->len = obj->end - obj->start;
		reply->buf = tal_strndup(reply, buf + obj->start, reply->len);
	}
	reply->off = 0;

	return send_response(command, NULL, NULL, NULL, reply);
}

static struct command_result *commando_error(struct command *cmd,
					     struct commando *incoming,
					     int ecode,
					     const char *fmt, ...)
	PRINTF_FMT(4, 5);

static struct command_result *commando_error(struct command *cmd,
					     struct commando *incoming,
					     int ecode,
					     const char *fmt, ...)
{
	struct reply *reply = tal(plugin, struct reply);
	va_list ap;

	reply->incoming = tal_steal(reply, incoming);
	reply->buf = tal_fmt(reply, "{\"error\":{\"code\":%i,\"message\":\"", ecode);
	va_start(ap, fmt);
	tal_append_vfmt(&reply->buf, fmt, ap);
	va_end(ap);
	tal_append_fmt(&reply->buf, "\"}}");
	reply->off = 0;
	reply->len = tal_bytelen(reply->buf) - 1;

	return send_response(cmd, NULL, NULL, NULL, reply);
}

struct cond_info {
	/* The commando message (and our parent!) */
	struct commando *incoming;

	/* Convenience pointer into incoming->contents */
	const char *buf;

	/* Array of tokens in buf */
	const jsmntok_t *toks;

	/* Method they asked for. */
	const jsmntok_t *method;

	/* Optional params and filter args. */
	const jsmntok_t *params;
	const jsmntok_t *filter;

	/* Prefix for commands we execute */
	const char *cmdid_prefix;
};

static struct cond_info *new_cond_info(const tal_t *ctx,
				       struct commando *incoming,
				       const jsmntok_t *toks STEALS,
				       const jsmntok_t *method,
				       const jsmntok_t *params,
				       const jsmntok_t *id,
				       const jsmntok_t *filter)
{
	struct cond_info *cinfo = tal(ctx, struct cond_info);

	cinfo->incoming = incoming;
	/* Convenience pointer, since contents is u8 */
	cinfo->buf = cast_signed(const char *, incoming->contents);
	cinfo->toks = tal_steal(cinfo, toks);
	cinfo->method = method;
	cinfo->params = params;
	cinfo->filter = filter;

	if (!id) {
		cinfo->cmdid_prefix = NULL;
		incoming->json_id = NULL;
	} else {
		cinfo->cmdid_prefix = json_strdup(cinfo, cinfo->buf, id);
		/* Includes quotes, if any! */
		incoming->json_id = tal_strndup(incoming,
						json_tok_full(cinfo->buf, id),
						json_tok_full_len(id));
	}
	return cinfo;
}

static struct command_result *execute_command(struct command *cmd,
					      struct cond_info *cinfo)
{
	struct out_req *req;

	/* We handle success and failure the same */
	req = jsonrpc_request_whole_object_start(cmd,
						 json_strdup(tmpctx, cinfo->buf, cinfo->method),
						 cinfo->cmdid_prefix,
						 cmd_done, cinfo->incoming);
	if (cinfo->params) {
		size_t i;
		const jsmntok_t *t;

		/* FIXME: This is ugly! */
		if (cinfo->params->type == JSMN_OBJECT) {
			json_object_start(req->js, "params");
			json_for_each_obj(i, t, cinfo->params) {
				json_add_jsonstr(req->js,
						 json_strdup(tmpctx, cinfo->buf, t),
						 json_tok_full(cinfo->buf, t+1),
						 json_tok_full_len(t+1));
			}
			json_object_end(req->js);
		} else {
			assert(cinfo->params->type == JSMN_ARRAY);
			json_array_start(req->js, "params");
			json_for_each_arr(i, t, cinfo->params) {
				json_add_jsonstr(req->js,
						 NULL,
						 json_tok_full(cinfo->buf, t),
						 json_tok_full_len(t));
			}
			json_array_end(req->js);
		}
	} else {
		json_object_start(req->js, "params");
		json_object_end(req->js);
	}

	if (cinfo->filter) {
		json_add_jsonstr(req->js, "filter",
				 json_tok_full(cinfo->buf, cinfo->filter),
				 json_tok_full_len(cinfo->filter));
	}
	return send_outreq(req);
}

static struct command_result *checkrune_done(struct command *cmd,
					     const char *method,
					     const char *buf,
					     const jsmntok_t *result,
					     struct cond_info *cinfo)
{
	bool valid;
	const char *err;

	err = json_scan(cmd, buf, result, "{valid:%}",
			JSON_SCAN(json_to_bool, &valid));
	if (err) {
		plugin_err(plugin, "Invalid checkrune response (%s) %.*s",
			   err,
			   json_tok_full_len(result),
			   json_tok_full(buf, result));
	}

	/* Shouldn't happen! */
	if (!valid) {
		return commando_error(cmd, cinfo->incoming,
				      COMMANDO_ERROR_REMOTE,
				      "Invalid rune");
	}

	return execute_command(cmd, cinfo);
}

static struct command_result *checkrune_failed(struct command *cmd,
					       const char *method,
					       const char *buf,
					       const jsmntok_t *result,
					       struct cond_info *cinfo)
{
	const jsmntok_t *msg = json_get_member(buf, result, "message");

	if (!msg) {
		plugin_err(plugin, "Invalid checkrune error %.*s",
			   json_tok_full_len(result),
			   json_tok_full(buf, result));
	}

	return commando_error(cmd, cinfo->incoming,
			      COMMANDO_ERROR_REMOTE_AUTH,
			      "Invalid rune: %.*s",
			      msg->end - msg->start, buf + msg->start);
}

static struct command_result *try_command(struct command *cmd,
					  struct commando *incoming STEALS)
{
	const jsmntok_t *toks, *method, *params, *runetok, *id, *filter;
	const char *buf = (const char *)incoming->contents;
	struct cond_info *cinfo;
	struct rune *rune;
	struct out_req *req;

	toks = json_parse_simple(incoming, buf, tal_bytelen(buf));
	if (!toks) {
		return commando_error(cmd, incoming, COMMANDO_ERROR_REMOTE,
				      "Invalid JSON");
	}

	if (toks[0].type != JSMN_OBJECT) {
		return commando_error(cmd, incoming, COMMANDO_ERROR_REMOTE,
				      "Not a JSON object");
	}
	method = json_get_member(buf, toks, "method");
	if (!method) {
		return commando_error(cmd, incoming, COMMANDO_ERROR_REMOTE,
				      "No method");
	}
	params = json_get_member(buf, toks, "params");
	if (params && (params->type != JSMN_OBJECT && params->type != JSMN_ARRAY)) {
		return commando_error(cmd, incoming, COMMANDO_ERROR_REMOTE,
				      "Params must be object or array");
	}
	filter = json_get_member(buf, toks, "filter");
	id = json_get_member(buf, toks, "id");
	if (!id) {
		return commando_error(cmd, incoming, COMMANDO_ERROR_REMOTE,
				      "missing id field");
	}
	runetok = json_get_member(buf, toks, "rune");
	if (!runetok) {
		return commando_error(cmd, incoming, COMMANDO_ERROR_REMOTE,
				      "Missing rune");
	}
	rune = rune_from_base64n(tmpctx, buf + runetok->start,
				 runetok->end - runetok->start);
	if (!rune) {
		return commando_error(cmd, incoming, COMMANDO_ERROR_REMOTE,
				      "Invalid rune");
	}
	/* Gather all the info we need to execute this command (steals toks). */
	cinfo = new_cond_info(incoming, incoming, toks, method, params, id, filter);

	/* Don't count this towards incomings anymore */
	destroy_commando(incoming, &incoming_commands);
	tal_del_destructor2(incoming, destroy_commando, &incoming_commands);

	req = jsonrpc_request_start(cmd, "checkrune",
				    checkrune_done, checkrune_failed,
				    cinfo);
	json_add_node_id(req->js, "nodeid", &incoming->peer);
	json_add_tok(req->js, "rune", runetok, cinfo->buf);
	json_add_tok(req->js, "method", method, cinfo->buf);
	if (params)
		json_add_tok(req->js, "params", params, cinfo->buf);
	return send_outreq(req);
}

static struct command_result *handle_incmd(struct command *cmd,
					   struct node_id *peer,
					   u64 idnum,
					   const u8 *msg, size_t msglen,
					   bool terminal)
{
	struct commando *incmd;

	incmd = find_commando(incoming_commands, peer, NULL);
	/* Don't let them buffer multiple commands: discard old. */
	if (incmd && incmd->id != idnum) {
		plugin_log(plugin, LOG_DBG, "New cmd from %s, replacing old",
			   fmt_node_id(tmpctx, peer));
		incmd = tal_free(incmd);
	}

	if (!incmd) {
		incmd = new_commando(plugin, NULL, peer, idnum);
		incmd->contents = tal_arr(incmd, u8, 0);
		tal_arr_expand(&incoming_commands, incmd);
		tal_add_destructor2(incmd, destroy_commando, &incoming_commands);

		/* More than 16 partial commands at once?  Free oldest */
		if (tal_count(incoming_commands) > 16)
			tal_free(incoming_commands[0]);
	}

	/* 1MB should be enough for anybody! */
	append_contents(incmd, msg, msglen, 1024*1024);

	if (!terminal)
		return command_hook_success(cmd);

	if (!incmd->contents) {
		plugin_log(plugin, LOG_UNUSUAL, "%s: ignoring oversize request",
			   fmt_node_id(tmpctx, peer));
		return command_hook_success(cmd);
	}

	return try_command(cmd, incmd);
}

static struct command_result *handle_reply(struct node_id *peer,
					   u64 idnum,
					   const u8 *msg, size_t msglen,
					   bool terminal)
{
	struct commando *ocmd;
	struct json_stream *res;
	const jsmntok_t *toks, *result, *err, *id;
	const char *replystr;
	size_t i;
	const jsmntok_t *t;

	ocmd = find_commando(outgoing_commands, peer, &idnum);
	if (!ocmd) {
		plugin_log(plugin, LOG_DBG,
			   "Ignoring unexpected %s reply from %s (id %"PRIu64")",
			   terminal ? "terminal" : "partial",
			   fmt_node_id(tmpctx, peer),
			   idnum);
		return NULL;
	}

	/* FIXME: We buffer, but ideally we would stream! */
	/* listchannels is 71MB, so we need to allow some headroom! */
	append_contents(ocmd, msg, msglen, 500*1024*1024);

	if (!terminal)
		return NULL;

	if (!ocmd->contents)
		return command_fail(ocmd->cmd, COMMANDO_ERROR_LOCAL, "Reply was oversize");

	replystr = (const char *)ocmd->contents;
	toks = json_parse_simple(ocmd, replystr, tal_bytelen(ocmd->contents));
	if (!toks || toks[0].type != JSMN_OBJECT)
		return command_fail(ocmd->cmd, COMMANDO_ERROR_LOCAL,
				    "Reply was unparsable: '%.*s'",
				    (int)tal_bytelen(ocmd->contents), replystr);

	id = json_get_member(replystr, toks, "id");

	/* Old commando didn't reply with id, but newer should get it right! */
	if (id && !memeq(json_tok_full(replystr, id), json_tok_full_len(id),
			 ocmd->json_id, strlen(ocmd->json_id))) {
		plugin_log(plugin, LOG_BROKEN, "Commando reply with wrong id:"
			   " I sent %s, they replied with %.*s!",
			   ocmd->json_id,
			   json_tok_full_len(id), json_tok_full(replystr, id));
	}

	err = json_get_member(replystr, toks, "error");
	if (err) {
		const jsmntok_t *code = json_get_member(replystr, err, "code");
		const jsmntok_t *message = json_get_member(replystr, err, "message");
		const jsmntok_t *datatok = json_get_member(replystr, err, "data");
		struct json_out *data;
		int ecode;
		if (!code || !json_to_int(replystr, code, &ecode)) {
			return command_fail(ocmd->cmd, COMMANDO_ERROR_LOCAL,
					    "Error '%.*s' had no valid code",
					    json_tok_full_len(err),
					    json_tok_full(replystr, err));
		}
		if (!message) {
			return command_fail(ocmd->cmd, COMMANDO_ERROR_LOCAL,
					    "Error had no message");
		}
		if (datatok) {
			data = json_out_new(ocmd->cmd);
			memcpy(json_out_direct(data, json_tok_full_len(datatok)),
			       json_tok_full(replystr, datatok),
			       json_tok_full_len(datatok));
		} else
			data = NULL;

		return command_done_err(ocmd->cmd, ecode,
					json_strdup(tmpctx, replystr, message),
					data);
	}

	result = json_get_member(replystr, toks, "result");
	if (!result)
		return command_fail(ocmd->cmd, COMMANDO_ERROR_LOCAL, "Reply had no result");

	res = jsonrpc_stream_success(ocmd->cmd);

	/* FIXME: This is ugly! */
	json_for_each_obj(i, t, result) {
		json_add_jsonstr(res,
				 json_strdup(tmpctx, replystr, t),
				 json_tok_full(replystr, t+1),
				 json_tok_full_len(t+1));
	}

	return command_finished(ocmd->cmd, res);
}

static struct command_result *handle_custommsg(struct command *cmd,
					      const char *buf,
					      const jsmntok_t *params)
{
	struct node_id peer;
	const u8 *msg;
	size_t len;
	enum commando_msgtype mtype;
	u64 idnum;

	json_to_node_id(buf, json_get_member(buf, params, "peer_id"), &peer);
	msg = json_tok_bin_from_hex(cmd, buf,
				    json_get_member(buf, params, "payload"));

	len = tal_bytelen(msg);
	mtype = fromwire_u16(&msg, &len);
	idnum = fromwire_u64(&msg, &len);

	if (msg) {
		switch (mtype) {
		case COMMANDO_MSG_CMD_CONTINUES:
		case COMMANDO_MSG_CMD_TERM:
			return handle_incmd(cmd, &peer, idnum, msg, len,
					    mtype == COMMANDO_MSG_CMD_TERM);
		case COMMANDO_MSG_REPLY_CONTINUES:
		case COMMANDO_MSG_REPLY_TERM:
			handle_reply(&peer, idnum, msg, len,
				     mtype == COMMANDO_MSG_REPLY_TERM);
			break;
		}
	}

	return command_hook_success(cmd);
}

static const struct plugin_hook hooks[] = {
	{
		"custommsg",
		handle_custommsg
	},
};

struct outgoing {
	struct node_id peer;
	size_t msg_off;
	u8 **msgs;
};

static struct command_result *send_more_cmd(struct command *cmd,
					    const char *method UNUSED,
					    const char *buf UNUSED,
					    const jsmntok_t *result UNUSED,
					    struct outgoing *outgoing)
{
	struct out_req *req;

	if (outgoing->msg_off == tal_count(outgoing->msgs)) {
		tal_free(outgoing);
		return command_still_pending(cmd);
	}

	req = jsonrpc_request_start(cmd, "sendcustommsg",
				    send_more_cmd, forward_error, outgoing);
	json_add_node_id(req->js, "node_id", &outgoing->peer);
	json_add_hex_talarr(req->js, "msg", outgoing->msgs[outgoing->msg_off++]);

	return send_outreq(req);
}

static struct command_result *json_commando(struct command *cmd,
					    const char *buffer,
					    const jsmntok_t *params)
{
	struct node_id *peer;
	const char *method, *cparams;
	const char *rune, *filter;
	struct commando	*ocmd;
	struct outgoing *outgoing;
	char *json;
	size_t jsonlen;
	u64 oid;

	if (!param(cmd, buffer, params,
		   p_req("peer_id", param_node_id, &peer),
		   p_req("method", param_string, &method),
		   p_opt("params", param_string, &cparams),
		   p_opt("rune", param_string, &rune),
		   p_opt("filter", param_string, &filter),
		   NULL))
		return command_param_failed();

	do {
		oid = pseudorand_u64();
	} while (find_commando(outgoing_commands, NULL, &oid));

	ocmd = new_commando(cmd, cmd, peer, oid);
	ocmd->contents = tal_arr(ocmd, u8, 0);
	ocmd->json_id = tal_strdup(ocmd, cmd->id);

	tal_arr_expand(&outgoing_commands, ocmd);
	tal_add_destructor2(ocmd, destroy_commando, &outgoing_commands);

	/* We pass through their JSON id untouched. */
	json = tal_fmt(tmpctx,
		       "{\"method\":\"%s\",\"id\":%s,\"params\":%s", method,
		       ocmd->json_id, cparams ? cparams : "{}");
	if (rune)
		tal_append_fmt(&json, ",\"rune\":\"%s\"", rune);
	if (filter)
		tal_append_fmt(&json, ",\"filter\":%s", filter);
	tal_append_fmt(&json, "}");

	outgoing = tal(cmd, struct outgoing);
	outgoing->peer = *peer;
	outgoing->msg_off = 0;
	/* 65000 per message gives sufficient headroom. */
	jsonlen = tal_bytelen(json)-1;
	outgoing->msgs = tal_arr(cmd, u8 *, (jsonlen + 64999) / 65000);
	for (size_t i = 0; i < tal_count(outgoing->msgs); i++) {
		u8 *cmd_msg = tal_arr(outgoing, u8, 0);
		bool terminal = (i == tal_count(outgoing->msgs) - 1);
		size_t off = i * 65000, len;

		if (terminal)
			len = jsonlen - off;
		else
			len = 65000;

		towire_u16(&cmd_msg,
			   terminal ? COMMANDO_MSG_CMD_TERM
			   : COMMANDO_MSG_CMD_CONTINUES);
		towire_u64(&cmd_msg, ocmd->id);
		towire(&cmd_msg, json + off, len);
		outgoing->msgs[i] = cmd_msg;
	}

	return send_more_cmd(cmd, NULL, NULL, NULL, outgoing);
}

/* Handles error or success */
static struct command_result *forward_reply(struct command *cmd,
					    const char *method,
					    const char *buf,
					    const jsmntok_t *result,
					    void *arg)
{
	const jsmntok_t *err = json_get_member(buf, result, "error");
	if (err)
		return forward_error(cmd, method, buf, err, arg);
	return forward_result(cmd, method, buf, json_get_member(buf, result, "result"), arg);
}

static struct command_result *forward_command(struct command *cmd,
					      const char *buffer,
					      const jsmntok_t *params,
					      const char *method)
{
	/* params could be an array, so use low-level helper */
	struct out_req *req;

	req = jsonrpc_request_whole_object_start(cmd, method, NULL,
						 forward_reply, NULL);
	json_add_tok(req->js, "params", params, buffer);
	return send_outreq(req);
}

static struct command_result *json_commando_rune(struct command *cmd,
						 const char *buffer,
						 const jsmntok_t *params)
{
	const char *unused1, *unused2;

	/* param call needed to generate help messages */
	if (!param(cmd, buffer, params,
		   p_opt("rune", param_string, &unused1),
		   p_opt("restrictions", param_string, &unused2),
		   NULL))
		return command_param_failed();

	return forward_command(cmd, buffer, params, "createrune");
}

static struct command_result *json_commando_blacklist(struct command *cmd,
						 const char *buffer,
						 const jsmntok_t *params)
{
	const char *unused1, *unused2;

	/* param call needed to generate help messages */
	if (!param(cmd, buffer, params,
		   p_opt("start", param_string, &unused1),
		   p_opt("end", param_string, &unused2),
		   NULL))
		return command_param_failed();

	return forward_command(cmd, buffer, params, "blacklistrune");
}

static struct command_result *json_commando_listrunes(struct command *cmd,
						 const char *buffer,
						 const jsmntok_t *params)
{
	const char *unused;

	/* param call needed to generate help messages */
	if (!param(cmd, buffer, params,
		   p_opt("rune", param_string, &unused), NULL))
		return command_param_failed();

	return forward_command(cmd, buffer, params, "showrunes");
}

static void memleak_mark_globals(struct plugin *p, struct htable *memtable)
{
	memleak_scan_obj(memtable, outgoing_commands);
	memleak_scan_obj(memtable, incoming_commands);
}

static const char *init(struct command *init_cmd,
			const char *buf UNUSED, const jsmntok_t *config UNUSED)
{
	plugin = init_cmd->plugin;
	outgoing_commands = tal_arr(plugin, struct commando *, 0);
	incoming_commands = tal_arr(plugin, struct commando *, 0);
	plugin_set_memleak_handler(plugin, memleak_mark_globals);

	return NULL;
}

static const struct plugin_command commands[] = { {
	"commando",
	json_commando,
	}, {
	"commando-rune",
	json_commando_rune,
	"v23.08",
	"v25.02",
	},
	{
	"commando-listrunes",
	json_commando_listrunes,
	"v23.08",
	"v25.02",
	},
	{
	"commando-blacklist",
	json_commando_blacklist,
	"v23.08",
	"v25.02",
	},
};

int main(int argc, char *argv[])
{
	setup_locale();
	plugin_main(argv, init, NULL, PLUGIN_STATIC, true, NULL,
		    commands, ARRAY_SIZE(commands),
	            NULL, 0,
		    hooks, ARRAY_SIZE(hooks),
		    NULL, 0,
		    NULL);
}